Tests

[AronBuzogany]

This PR fixes #21

[pheyvaer]

Is the "Testing" section of the README up to date?

[AronBuzogany]

Is the "Testing" section of the README up to date?

No, I have updated it in commit 1d852c1

[pheyvaer]

Is the "Testing" section of the README up to date?

No, I have updated it in commit 1d852c1

Did you try every step yourself?

[AronBuzogany]

Did you try every step yourself?

Just did again, it works for me

[pheyvaer]

Did you try every step yourself?

Just did again, it works for me

Weird, because when I do the second step with npm start I get this error

npm ERR! Missing script: "start"

[AronBuzogany]

Weird, because when I do the second step with npm start I get this error

Ah, yes, my bad, I have custom npm commands configured so I didn't notice.

You would probably get the same for npm test

I have updated it in commit 362d13e

[pheyvaer]

"Log in and execute query on private data" and "Querying resource with "bad" cors header, though a proxy should work" doesn't work for me. I think it's related to the fact that when the app starts immediately the first query is executed. There is a PR #31 to fix this.

[AronBuzogany]

Strange, I just executed it locally and they all passed.

I tried it with cypress open instead of cypress run also, and it doesn't seem to be doing anything weird.

[pheyvaer]

@AronBuzogany Can you merge main into the branch and then see if everything still works for you?

[AronBuzogany]

@AronBuzogany Can you merge main into the branch and then see if everything still works for you?

they still all succeed

[pheyvaer]

Ok. Can you remove all DBpedia data sources from the tests? It's best not to rely on remote resources for testing.

[AronBuzogany]

Yes, in that case I will just replace all the queries which don't query locally hosted resources

[AronBuzogany]

Ok. Can you remove all DBpedia data sources from the tests? It's best not to rely on remote resources for testing.

They are now all removed except for the ask query as it is not implemented yet #22

All tests still succeed

[pheyvaer]

I see there is startBadCorsServer.mjs but it doesn't seem like we start it anywhere? Is that correct?

[AronBuzogany]

I see there is startBadCorsServer.mjs but it doesn't seem like we start it anywhere? Is that correct?

Correct, I haven't got there yet. It is now however in the README and a script in package.json

Should we do something about the number of processes running up? Or is it okay as is?