Fix/90 #97
Merged
Fix/90 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbrab
requested changes
Mar 27, 2024
Collaborator
There was a problem hiding this comment.
- Update CHANGELOG
- Mixing false, true and numberic values read from response.status into the same variable is bad practice. Solution; rename fetchSuccess into fetchStatus and make it an object with 2 properties (a bool success and a number responseStatus). If the bool is false and the responseStatus is 401 or 403, show the unauthorized icon. If the bool is false is and the responseStatus is something else, show the failed icon. If the bool is true, show the success icon.
- Consider also (403, see remark above and the comment in #90)
mvanbrab
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90