Add linting #29
Merged
Add linting #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| You run the linter via | ||
| ```shell | ||
| npm run lint:ts |
Collaborator
There was a problem hiding this comment.
running this gives me an output as,
✖ 535 problems (101 errors, 434 warnings)
0 errors and 2 warnings potentially fixable with the `--fix` option.So, the linting looks good to me. I will try to fix theese errors and warnings. Would add tests after this in a seperate pull request.
@pheyvaer Should I ping you once,
- The linting errors are sorted.
- Most of the coverage is done.?
Contributor
Author
There was a problem hiding this comment.
Ok, in that case
- Merge this PR.
- Create a new branch were you fix the linting errors. The corresponding issue is Fix linting errors #30
- Make a PR with that new branch.
- Assign me as a reviewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added linting to the repo. I added instructions for it in the README. I already automatically fixed some of the issues, but there are some left. Most of them are about the documentation, which is crucial for me to understand what is happening. If you are ok with how the linting is set up, can you then have a look at fixing the remaining issues? This should happen in a separate branch.