Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3 tasks
There was a problem hiding this comment.
Pull request overview
Refactors the folder pane’s inline styling into a dedicated CSS file and adds Webpack-based configs plus a standalone dev server harness to preview the pane locally (per SolidOS/solidos#244).
Changes:
- Move several inline style mutations in the pane renderer into
src/styles/folderPane.cssand apply via class names. - Add shared Webpack module rules and separate dev/prod Webpack configs (including copying styles to
lib/stylesin the webpack build). - Add a
dev/harness (HTML/CSS/JS + minimal outliner adapter) andnpm startto run a local dev server.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
webpack.module.rules.mjs |
Adds JS/TS + CSS(+CSS modules) + TTL loader rules for webpack builds. |
webpack.dev.config.mjs |
Adds webpack-dev-server config for the new dev harness. |
webpack.config.mjs |
Adds production webpack configs (normal + min) and copies styles into lib/styles. |
src/styles/folderPane.css |
Introduces dedicated CSS classes replacing prior inline styles. |
src/index.ts |
Imports CSS and swaps inline styling for CSS classes. |
package.json |
Updates entry fields, adds CSS sideEffects, adds dev server script, and adds webpack-related devDependencies. |
dev/index.js |
Adds a runnable dev harness that renders the pane against a target container. |
dev/index.html |
Adds the dev page scaffold for webpack’s HtmlWebpackPlugin. |
dev/dev-global.css |
Adds dev-only global styling/variables to simulate mashlib styling. |
dev/context.js |
Adds a minimal Solid “context” object used by the dev harness. |
Comments suppressed due to low confidence (2)
src/index.ts:134
- Minor:
explictDropIconis misspelled; renaming toexplicitDropIconwould improve readability and reduce the chance of propagating the typo.
src/index.ts:8 lib/index.jswill include animport './styles/folderPane.css', but the current build (tsc) does not copy CSS intolib/styles. As a result, consumers (and your published package viafiles: ['lib/']) will be missing the CSS file. Add a build step to copysrc/styles/*.cssintolib/styles(or change the import/publish strategy).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…dOS/folder-pane into refactor/styles-separateCSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket SolidOS/solidos#244