Skip to content

Refactor styles into separate CSS#160

Open
SharonStrats wants to merge 23 commits intomainfrom
refactor/styles-separateCSS
Open

Refactor styles into separate CSS#160
SharonStrats wants to merge 23 commits intomainfrom
refactor/styles-separateCSS

Conversation

@SharonStrats
Copy link

SharonStrats and others added 17 commits March 13, 2026 20:59
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the folder pane’s inline styling into a dedicated CSS file and adds Webpack-based configs plus a standalone dev server harness to preview the pane locally (per SolidOS/solidos#244).

Changes:

  • Move several inline style mutations in the pane renderer into src/styles/folderPane.css and apply via class names.
  • Add shared Webpack module rules and separate dev/prod Webpack configs (including copying styles to lib/styles in the webpack build).
  • Add a dev/ harness (HTML/CSS/JS + minimal outliner adapter) and npm start to run a local dev server.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
webpack.module.rules.mjs Adds JS/TS + CSS(+CSS modules) + TTL loader rules for webpack builds.
webpack.dev.config.mjs Adds webpack-dev-server config for the new dev harness.
webpack.config.mjs Adds production webpack configs (normal + min) and copies styles into lib/styles.
src/styles/folderPane.css Introduces dedicated CSS classes replacing prior inline styles.
src/index.ts Imports CSS and swaps inline styling for CSS classes.
package.json Updates entry fields, adds CSS sideEffects, adds dev server script, and adds webpack-related devDependencies.
dev/index.js Adds a runnable dev harness that renders the pane against a target container.
dev/index.html Adds the dev page scaffold for webpack’s HtmlWebpackPlugin.
dev/dev-global.css Adds dev-only global styling/variables to simulate mashlib styling.
dev/context.js Adds a minimal Solid “context” object used by the dev harness.
Comments suppressed due to low confidence (2)

src/index.ts:134

  • Minor: explictDropIcon is misspelled; renaming to explicitDropIcon would improve readability and reduce the chance of propagating the typo.
    src/index.ts:8
  • lib/index.js will include an import './styles/folderPane.css', but the current build (tsc) does not copy CSS into lib/styles. As a result, consumers (and your published package via files: ['lib/']) will be missing the CSS file. Add a build step to copy src/styles/*.css into lib/styles (or change the import/publish strategy).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants