Mirror new CSS tokens from light.css into dark.css#344
Merged
timea-solid merged 2 commits intoprofileEditA11yfrom Mar 23, 2026
Merged
Mirror new CSS tokens from light.css into dark.css#344timea-solid merged 2 commits intoprofileEditA11yfrom
timea-solid merged 2 commits intoprofileEditA11yfrom
Conversation
Open
Co-authored-by: timea-solid <4144203+timea-solid@users.noreply.github.com> Agent-Logs-Url: https://github.com/SolidOS/mashlib/sessions/fc474993-e7a9-44a2-8238-ad3361eb9c58
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on updated CSS variables in original PR
Mirror new CSS tokens from light.css into dark.css
Mar 23, 2026
timea-solid
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent PR (#342) introduced 17 new CSS custom properties to
light.csswith no corresponding dark-theme overrides, causing dark mode to silently fall back to light values — producing low-contrast or visually inconsistent UI.Changes
src/styles/themes/dark.css--color-border-accent: #9999dd(lightened from light's#8888ccfor dark-background contrast)--spacing-xxxs,--spacing-xxs,--spacing-btn,--border-width-xthin,--border-width-sm,--border-radius-xs,--border-radius-sm) — values match light theme (layout/size, not color)--overlay-bg-muted: rgba(0, 0, 0, 0.5)(vs.0.3in light)--opacity-input-disabled: 0.75,--grid-min-column: 30em(theme-neutral, kept identical)📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.