Do not modify the History on direct links#85
Merged
Conversation
When arriving at a page through a direct link, that page is already added to the browser's History. Thus, if we added it through history.pushState again, it'll be duplicate, and the browser's Back button no longer works.
megoth
approved these changes
May 14, 2019
Contributor
megoth
left a comment
megoth
left a comment
There was a problem hiding this comment.
Tested and verified on my local setup ^_^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When arriving at a page through a direct link, that page is already
added to the browser's History. Thus, if we added it through
history.pushState again, it'll be duplicate, and the browser's Back
button no longer works.
Fixes nodeSolidServer/node-solid-server#1094.