[WIP] Implement reusable primitives#761
Draft
NoelDeMartin wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up from #748, and it implements some reusable "primitive" components alongside a new Solid UI component (
<solid-ui-account>).Here's a summary of the most relevant points:
solid-logic, but other applications won't).<solid-ui-menu>) are not very accessible. This is something I want to continue exploring as we work on these.:state()selector or the Popover API. I have already thought on some ways to polyfill them, or even replace them, but for now I think it's ok to use them until we decide on the final direction.