Skip to content

MathUtil, NumberUtil, StartupUtil Quick fixes#141

Merged
aakatz3 merged 6 commits intomasterfrom
fixup/qol-quickfixes
May 29, 2021
Merged

MathUtil, NumberUtil, StartupUtil Quick fixes#141
aakatz3 merged 6 commits intomasterfrom
fixup/qol-quickfixes

Conversation

@aakatz3
Copy link
Copy Markdown
Collaborator

@aakatz3 aakatz3 commented May 29, 2021

A couple super simple fixes that i want rn

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2021

Codecov Report

Merging #141 (d53c6ec) into master (3316338) will increase coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head d53c6ec differs from pull request most recent head f409adc. Consider uploading reports for the commit f409adc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   34.51%   34.72%   +0.20%     
==========================================
  Files          63       63              
  Lines        2532     2534       +2     
  Branches      286      286              
==========================================
+ Hits          874      880       +6     
+ Misses       1595     1591       -4     
  Partials       63       63              
Impacted Files Coverage Δ
.../dumbdogdiner/stickyapi/bukkit/util/SoundUtil.java 0.00% <ø> (ø)
...umbdogdiner/stickyapi/bukkit/util/StartupUtil.java 0.00% <ø> (ø)
...m/dumbdogdiner/stickyapi/common/util/MathUtil.java 33.33% <100.00%> (+8.33%) ⬆️
...dumbdogdiner/stickyapi/common/util/NumberUtil.java 59.25% <100.00%> (+7.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3316338...f409adc. Read the comment docs.

@aakatz3 aakatz3 requested a review from jcxldn May 29, 2021 20:34
@jcxldn jcxldn force-pushed the fixup/qol-quickfixes branch from d53c6ec to f409adc Compare May 29, 2021 20:49
@jcxldn jcxldn changed the title Quick fixes MathUtil, NumberUtil, StartupUtil Quick fixes May 29, 2021
@kaylendog kaylendog self-requested a review May 29, 2021 20:50
@aakatz3 aakatz3 merged commit 262edf1 into master May 29, 2021
@jcxldn jcxldn deleted the fixup/qol-quickfixes branch May 29, 2021 20:51
@jcxldn jcxldn restored the fixup/qol-quickfixes branch May 29, 2021 20:51
kaylendog added a commit that referenced this pull request May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants