Skip to content

Move to ansible for demo setup#1024

Merged
PaulMorris merged 3 commits into
masterfrom
ansible
Sep 24, 2018
Merged

Move to ansible for demo setup#1024
PaulMorris merged 3 commits into
masterfrom
ansible

Conversation

@jvasile
Copy link
Copy Markdown
Contributor

@jvasile jvasile commented Aug 14, 2018

This patch takes all the steps in the install.sh and recasts them as an ansible role. It replaces the original install.sh script with a couple lines that invoke ansible.

@jvasile jvasile requested a review from kfogel August 14, 2018 07:27
@jvasile jvasile added the review label Aug 14, 2018
@jvasile
Copy link
Copy Markdown
Contributor Author

jvasile commented Aug 14, 2018

Hmm... this is failing some manual testing. I'll fix and update it.

@PaulMorris
Copy link
Copy Markdown
Contributor

PaulMorris commented Aug 14, 2018

@jvasile The install.sh doesn't have the latest steps to set up and seed the database (the Liquibase migrations). These are in INSTALL.md > Build and deploy the application > 4. Create database schema and initial data. So we'll need to add those to the ansible role.

@PaulMorris
Copy link
Copy Markdown
Contributor

I added a commit that adds the liquibase db setup step. I haven't had a chance to test this yet.

@frankduncan
Copy link
Copy Markdown

I noticed that the "Seed Database" still cats seed.sql, so that can be removed.

Otherwise, this all looks straightforward and correct to me. I don't have an ubuntu or fedora machine handy, but we may want to create an issue to track the idea of making ansible the default way to install the app on jenkins in the future, otherwise this will only ever get tested when someone new onboards, and the likelihood of it going stale is probably pretty high.

And remove seed.sql file from database setup since it is no
longer needed.
@PaulMorris
Copy link
Copy Markdown
Contributor

I've removed the "seed.sql" file from the "Seed Database" step. Will go ahead and merge since this is more up-to-date than the script it is replacing.

@PaulMorris
Copy link
Copy Markdown
Contributor

I've opened Issue #1099 "Use ansible script for installing on Jenkins" to track that idea, as @frankduncan suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants