Added CRD controller #115
Merged
Added CRD controller #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To test the CRD:
|
shaikatz
reviewed
Apr 4, 2019
src/crd-controller/HealthChecks/KubernetesPermissionsHelthCheck.cs
Outdated
Show resolved
Hide resolved
shaikatz
reviewed
Apr 4, 2019
shaikatz
reviewed
Apr 4, 2019
| public Dictionary<string, string> Data { get; set; } | ||
| public string Type { get; set; } | ||
| public V1ObjectMeta Metadata { get; set; } | ||
| public string ServiceAccount { get; set; } |
Contributor
There was a problem hiding this comment.
Isn't that an issue where the property names are capitalized here and camel cased in the KamusSecret k8s object (in the docs)?
Contributor
Author
There was a problem hiding this comment.
It worked, I'm not 100% sure why 🤷♂️
shaikatz
reviewed
Apr 4, 2019
shaikatz
reviewed
Apr 4, 2019
shaikatz
reviewed
Apr 4, 2019
| <PackageReference Include="KubernetesClient" Version="1.5.1-g60ffd20a7c" /> | ||
| <PackageReference Include="System.Net.Http" Version="4.3.3" /> | ||
| <PackageReference Include="App.Metrics.AspNetCore.Mvc" Version="2.0.0" /> | ||
| <PackageReference Include="App.Metrics.Formatters.Prometheus" Version="2.0.0" /> |
Contributor
There was a problem hiding this comment.
Please update both AppMetrics packages to version 3 for newest Prometheus support
shaikatz
suggested changes
Apr 4, 2019
Contributor
shaikatz
left a comment
shaikatz
left a comment
There was a problem hiding this comment.
Wow amazing job, that feature will open cool use cases for kamus, storing native k8s secrets but in a GitOps way!
Oh, left some small comments.
Contributor
Author
|
Cool, thanks! Just left to fight the build :) |
shaikatz
previously approved these changes
Apr 4, 2019
Merged
added 13 commits
April 11, 2019 14:02
Co-Authored-By: omerlh <omerlh@users.noreply.github.com>
Co-Authored-By: omerlh <omerlh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very first MVP version of the CRD. Currently, only create and delete are supported.
In order to finish this task we need:
Want to give it a try? You can build the images locally, and use
crd.yamlandtls.yamlto test it out.close #13