Skip to content

feat: add template#1

Merged
qamarq merged 9 commits into
mainfrom
feat/add-template
Apr 13, 2025
Merged

feat: add template#1
qamarq merged 9 commits into
mainfrom
feat/add-template

Conversation

@Octopus4344
Copy link
Copy Markdown
Member

@Octopus4344 Octopus4344 commented Apr 3, 2025

Jest templatka webowa, nie wiem czy cos jeszcze jest tutaj potrzebne

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Apr 3, 2025
@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Apr 6, 2025
@Octopus4344 Octopus4344 requested a review from qamarq April 6, 2025 16:44
Copy link
Copy Markdown
Member

@qamarq qamarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kilka uwag mam ale ogolnie mega robota <3

Comment thread .github/workflows/ci.yml
Comment thread components.json
Comment thread package.json
"dev": "next dev",
"format": "prettier --write .",
"format:check": "prettier --check .",
"lint": "next lint",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trzymalbym sie jedenj konwencji czyli jak mamy format i format:check to zeby lint fixowal a lint:check sprawdzal, tylko wtedy update github actions, albo w druga strone, lint i lint:fix i format i format:fix. jak wolisz ale jednolicie

Suggested change
"lint": "next lint",
"lint": "next lint --fix",
"lint:check": "next lint --max-warnings=0",

Comment thread src/app/globals.css
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuuu fajnie batdzo ze tailwind v4

Comment thread src/app/layout.tsx
Comment on lines +25 to +29
<QueryProvider>
<body className={`${space_grotesk.variable} font-sans antialiased`}>
{children}
</body>
</QueryProvider>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wydzielibym queryprovider to osobnego pliku /components/providers.tsx zeby od razu bylo to w pliku i zeby moc pozniej dodawac nastepne providery i nie smiecic tu, dodatkowo moze pomysl nad ciemnym i jasnym motywem od razu, moim zdaniem fajnie by bylo juz go miec: https://ui.shadcn.com/docs/dark-mode/next

Comment thread src/app/page.tsx
<footer className="absolute right-0 bottom-0 left-0 p-4 text-center text-white">
<p className="text-sm">
Made with ❤️ by{" "}
<Link href="https://solvro.pwr.edu.pl/pl/"> Solvro </Link>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wez wywal to /pl na koncu zeby sie odpalalo autoamtcyznie w dobrym jezyku

Copy link
Copy Markdown
Member

@qamarq qamarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dobra pozniej to ogarniesz, merguje bo potrzebujemy, good job :*

@qamarq qamarq merged commit 27717d5 into main Apr 13, 2025
1 check passed
@qamarq qamarq deleted the feat/add-template branch April 13, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants