Skip to content

workaround for 'forceZeroCoverage' #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2016
Merged

workaround for 'forceZeroCoverage' #1007

merged 1 commit into from
Dec 21, 2016

Conversation

@guwirth
Copy link
Collaborator

@guwirth guwirth commented Dec 15, 2016 •
edited
Loading

@guwirth guwirth added the bug label Dec 15, 2016
@guwirth guwirth added this to the 0.9.7 milestone Dec 15, 2016
@guwirth guwirth self-assigned this Dec 15, 2016
@guwirth guwirth changed the title try workaround for 'forceZeroCoverage' workaround for 'forceZeroCoverage' Dec 16, 2016
@guwirth
workaround for 'forceZeroCoverage'
ae924e0 
* add a FileLinesVisitor
* add 'sonar.cxx.coverage.forceZeroCoverage' again with PropertyDefinition
* close #999
* close #909
@guwirth
Copy link
Collaborator Author

guwirth commented Dec 16, 2016

@ALL ready to review. Brings back the sonar.cxx.coverage.forceZeroCoverage feature.

@guwirth guwirth requested review from Bertk and jmecosta December 16, 2016 17:03
jmecosta
jmecosta approved these changes Dec 16, 2016
View reviewed changes
sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/metrics/FileLinesVisitor.java
* Visitor that computes {@link CoreMetrics#NCLOC_DATA_KEY} and
* {@link CoreMetrics#COMMENT_LINES_DATA_KEY} metrics used by the DevCockpit.
*/
public class FileLinesVisitor extends SquidAstVisitor<Grammar> implements AstAndTokenVisitor {
Copy link
Member

@jmecosta jmecosta Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called filesexecutedlinesvisitor?

@guwirth
Copy link
Collaborator Author

guwirth commented Dec 21, 2016

I did a test with our projects: works fine for us.

@guwirth guwirth merged commit 66ad066 into SonarOpenCommunity:master Dec 21, 2016
@guwirth guwirth deleted the forceZeroCoverage-workaround branch February 17, 2017 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmecosta jmecosta jmecosta approved these changes

@Bertk Bertk Awaiting requested review from Bertk

Assignees

@guwirth guwirth

Labels

bug

Milestone

0.9.7

Development

Successfully merging this pull request may close these issues.

coverage issues with SQ6.2 figure out what to do with forceZeroCoverage feature that does not work anymore in batch side

2 participants

@guwirth @jmecosta