Skip to content

BUILD-8621 Build npm action#15

Merged
mikolaj-matuszny-ext-sonarsource merged 3 commits intomasterfrom
feat/mmatuszny/BUILD-8097-npm-build
Jul 24, 2025
Merged

BUILD-8621 Build npm action#15
mikolaj-matuszny-ext-sonarsource merged 3 commits intomasterfrom
feat/mmatuszny/BUILD-8097-npm-build

Conversation

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource commented Jul 22, 2025

Adds new NPM build GitHub Action with comprehensive CI/CD pipeline support.

  • Creates reusable action that handles building, testing, SonarQube analysis, and Artifactory deployment
  • Implements branch-specific build logic (main, maintenance, PR, feature branches) with different deployment strategies
  • Integrates Vault for secure credential management and generates detailed workflow summaries
  • Includes mise configuration for consistent tooling (JFrog CLI 2.77.0, jq 1.8.1)

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Build npm - initial version BUILD-8621 Build npm - initial version Jul 22, 2025
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build branch 8 times, most recently from d3c212f to 90a3ed1 Compare July 23, 2025 10:08
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Adds new NPM build GitHub Action with comprehensive CI/CD pipeline support.

  • Creates reusable action that handles building, testing, SonarQube analysis, and Artifactory deployment
  • Implements branch-specific build logic (main, maintenance, PR, feature branches) with different deployment strategies
  • Integrates Vault for secure credential management and generates detailed workflow summaries
  • Includes mise configuration for consistent tooling (JFrog CLI 2.77.0, jq 1.8.1)

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource changed the title BUILD-8621 Build npm - initial version BUILD-8621 Build npm action Jul 23, 2025
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource marked this pull request as ready for review July 23, 2025 11:48
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource requested a review from a team July 23, 2025 11:48
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build branch 4 times, most recently from 5e3766c to 774a3f4 Compare July 23, 2025 12:00
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build branch from 774a3f4 to 4de8ab1 Compare July 23, 2025 12:02
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build.sh can be simplified to be shorter and easier to read.

Remove the run_npm_install, run_npm_tests, run_npm_build functions. They only make it harder to understand run_standard_pipeline with obfuscating simple commands.

Comment thread build-npm/action.yml Outdated
Comment thread build-npm/action.yml Outdated
Comment thread build-npm/action.yml
Comment thread build-npm/action.yml Outdated
Comment thread build-npm/action.yml Outdated
Comment thread build-npm/build.sh Outdated
Comment thread build-npm/build.sh Outdated
Comment thread build-npm/build.sh
Comment thread spec/build-npm_spec.sh Outdated
Comment thread spec/build-npm_spec.sh
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build branch 9 times, most recently from 1686585 to 4f9b3bf Compare July 24, 2025 10:19
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build branch 3 times, most recently from 86d6105 to fbdd793 Compare July 24, 2025 10:46
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build branch from fbdd793 to 6df3cc9 Compare July 24, 2025 11:08
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Add new build-npm action for NPM project CI/CD with SonarQube integration and Artifactory deployment.

  • New action: Created build-npm with comprehensive NPM build pipeline including testing, SonarQube analysis, and JFrog deployment
  • Version management: Implements dynamic versioning with build numbers and SNAPSHOT handling for different branch types
  • Branch strategy: Supports main, maintenance, PR, dogfood, and long-lived feature branches with different deployment rules
  • Configuration: Added mise.local.toml for tool versions and updated coverage settings to include build-npm
  • Documentation: Added detailed README section with usage examples, inputs/outputs, and feature descriptions
  • Testing: Comprehensive test suite with 400+ lines covering all build scenarios and utility functions

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource merged commit 1280596 into master Jul 24, 2025
10 checks passed
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource deleted the feat/mmatuszny/BUILD-8097-npm-build branch July 24, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants