Skip to content

BUILD-8097 Add missing test cases#18

Merged
mikolaj-matuszny-ext-sonarsource merged 1 commit intomasterfrom
feat/mmatuszny/BUILD-8097-npm-build-spec
Jul 28, 2025
Merged

BUILD-8097 Add missing test cases#18
mikolaj-matuszny-ext-sonarsource merged 1 commit intomasterfrom
feat/mmatuszny/BUILD-8097-npm-build-spec

Conversation

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource commented Jul 25, 2025

Add more tests to achieve 100% coverage

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build-spec branch 5 times, most recently from c96e03f to 857aace Compare July 25, 2025 10:31
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource marked this pull request as ready for review July 25, 2025 10:32
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource requested a review from a team July 25, 2025 10:32
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build-spec branch 4 times, most recently from 0f7d6bc to 7e6b45f Compare July 25, 2025 11:46
@hedinasr
Copy link
Copy Markdown
Contributor

@mikolaj-matuszny-ext-sonarsource don't forget to squash and change the commit message.

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build-spec branch from 7e6b45f to ef31aa9 Compare July 28, 2025 09:40
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8097-npm-build-spec branch from ef31aa9 to 822f0d5 Compare July 28, 2025 10:16
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Updates NPM build script with improved version handling and test coverage.

• Improved version format validation to use semantic versioning regex instead of dot counting
• Enhanced SNAPSHOT version handling for maintenance branches with automatic build number appending
• Added support for 2-digit versions by automatically appending .0 when needed
• Expanded test coverage with comprehensive error scenarios and edge cases
• Fixed git mock behavior for shallow repository detection in tests
• Added .DS_Store to .gitignore and updated shellspec coverage pattern

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource merged commit 16af85e into master Jul 28, 2025
8 checks passed
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource deleted the feat/mmatuszny/BUILD-8097-npm-build-spec branch July 28, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants