BUILD-10835 Use warp-custom-ubuntu-24-04 instead of github-ubuntu-latest-s#252
Conversation
hedinasr
force-pushed
the
fix/hnasr/BUILD-10835-warpReplaceGithubUbuntuLatest
branch
7 times, most recently
from
5a5d789 to
4b8bd9e
Compare
…est-s Shared workflows and actionlint: use WarpBuild general-purpose Ubuntu (warp-custom-ubuntu-24-04) instead of github-ubuntu-latest-s, including check-sca.yml on current master. https://sonarsource.atlassian.net/browse/BUILD-10835
hedinasr
force-pushed
the
fix/hnasr/BUILD-10835-warpReplaceGithubUbuntuLatest
branch
from
4b8bd9e to
512bb68
Compare
SummaryThis PR migrates 12 workflow files and the actionlint config from There are two secondary changes in What reviewers should knowWhere to start: Review the actionlint change first (single line, validates the config against the new runner label), then scan a few workflow files to confirm the pattern is consistent. Key observations:
Questions for the author:
|
![sonar-review-alpha[bot]](https://avatars.githubusercontent.com/in/3025063?s=60&v=4){kind=small}
There was a problem hiding this comment.
The runner migrations are straightforward and mechanically correct, but the test-build-number workflow contains a non-trivial behavioral change that needs explanation, and mise.toml adds two tool versions that appear unrelated to the runner migration.
There was a problem hiding this comment.
Pull request overview
Updates CI workflows to run on the WarpBuild Ubuntu 24.04 runner label instead of github-ubuntu-latest-s, and adjusts lint configuration accordingly. It also expands the repo-level mise toolchain, which affects what gets installed in CI jobs that run mise.
Changes:
- Replaced
runs-on: github-ubuntu-latest-swithruns-on: warp-custom-ubuntu-24-04across multiple workflows. - Updated
.github/actionlint.yamlrunner label allowlist to includewarp-custom-ubuntu-24-04. - Added Node and Python tool pins to
mise.toml(and added additional setup steps intest-build-number.yml’s aggregate job).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| mise.toml | Adds Node + Python tool pins to the mise-managed toolchain. |
| .github/workflows/unified-dogfooding.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/test-shell-scripts.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/test-pr-cleanup.yml | Switches runner label(s) to warp-custom-ubuntu-24-04. |
| .github/workflows/test-build-number.yml | Switches runner label(s) to warp-custom-ubuntu-24-04 and modifies the aggregate job setup. |
| .github/workflows/SubmitReview.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/slack_notify.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/RequestReview.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/PullRequestCreated.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/PullRequestClosed.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/pre-commit.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/pr-cleanup.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/workflows/check-sca.yml | Switches runner label to warp-custom-ubuntu-24-04. |
| .github/actionlint.yaml | Updates actionlint self-hosted runner label allowlist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
BUILD-10835
Purpose
Use
warp-custom-ubuntu-24-04(WarpBuild) instead ofgithub-ubuntu-latest-sacross shared workflows and actionlint allowlist.Scope
.github/workflows/*(all jobs that still referencedgithub-ubuntu-latest-s, includingcheck-sca.ymlfrommaster).github/actionlint.yamlself-hosted runner label listNotes
README / internal migration notes under
.cursor/still mention the old GitHub-hosted label in places; say if you want those updated in a follow-up.