Skip to content

BUILD-10835 Remove slack_notify reusable workflow#253

Merged
hedinasr merged 1 commit into
masterfrom
feat/hnasr/BUILD-10835-slackNotifySonarXs
May 13, 2026
Merged

BUILD-10835 Remove slack_notify reusable workflow#253
hedinasr merged 1 commit into
masterfrom
feat/hnasr/BUILD-10835-slackNotifySonarXs

Conversation

@hedinasr
Copy link
Copy Markdown
Contributor

@hedinasr hedinasr commented May 13, 2026

BUILD-10835 This change removes the slack_notify reusable workflow from ci-github-actions.

The workflow triggered on check_suite: completed and forwarded results to Slack. It is dropped as part of the BUILD-10835 CI consolidation so this repo no longer ships or maintains that entry point.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 13, 2026

BUILD-10835

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource marked this pull request as ready for review May 13, 2026 12:13
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource requested a review from a team as a code owner May 13, 2026 12:13
@sonar-review-alpha
Copy link
Copy Markdown
Contributor

sonar-review-alpha Bot commented May 13, 2026

Summary

This PR removes .github/workflows/slack_notify.yml, a reusable workflow that automatically sent Slack notifications when check suites completed. The workflow was part of ci-github-actions' public API surface for external repositories to use, so removal is a breaking change for any downstream consumers. This aligns with the BUILD-10835 CI consolidation effort to streamline the repo's maintained workflows.

The change is straightforward: a single file deletion. No other workflows reference slack_notify.yml, and the Slack notification logic appears to have been consolidated elsewhere (or deprecated entirely as part of this initiative).

What reviewers should know

What to verify:

  • Check that no internal SonarSource workflows still reference this workflow (search existing workflows for slack_notify)
  • Confirm downstream teams have been notified about the breaking change (check linked JIRA BUILD-10835 or related communications)
  • Verify the squad-eng-xp-github Slack channel is receiving notifications through an alternative mechanism if still needed

Scope: File deletion only—no changes to other workflows or code. The workflow was self-contained with no internal dependencies.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown
Contributor

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, minimal change. The runner label swap in slack_notify.yml and the corresponding actionlint.yaml allowlist update are consistent and complete — nothing was missed.

🗣️ Give feedback

Remove `.github/workflows/slack_notify.yml` from this repository as part of the BUILD-10835 CI cleanup.

The workflow listened for `check_suite` completion and posted to Slack; it is no longer maintained here.
Copilot AI review requested due to automatic review settings May 13, 2026 12:38
@hedinasr hedinasr force-pushed the feat/hnasr/BUILD-10835-slackNotifySonarXs branch from 87a4fb2 to 0250922 Compare May 13, 2026 12:38
@hedinasr hedinasr changed the title BUILD-10835 Use sonar-xs runner for slack_notify workflow BUILD-10835 Remove slack_notify reusable workflow May 13, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the slack_notify reusable GitHub Actions workflow from this repository as part of BUILD-10835 CI consolidation, so this repo no longer provides the check_suite: completed → Slack forwarding entry point.

Changes:

  • Deleted .github/workflows/slack_notify.yml, removing the check_suite trigger and Slack notification job.
  • Eliminated the dependency on SonarSource/gh-action_slack-notify from this repo (as the workflow is no longer shipped).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

@hedinasr hedinasr merged commit 4400164 into master May 13, 2026
18 of 19 checks passed
@hedinasr hedinasr deleted the feat/hnasr/BUILD-10835-slackNotifySonarXs branch May 13, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants