Skip to content

BUILD-11388: Change pre-commit hook to koalaman/shellcheck-precommit#256

Merged
bwalsh434 merged 1 commit into
masterfrom
bugfix/bwalsh/BUILD-11388-fix-pre-commit-config-for-warpbuild-runners
May 15, 2026
Merged

BUILD-11388: Change pre-commit hook to koalaman/shellcheck-precommit#256
bwalsh434 merged 1 commit into
masterfrom
bugfix/bwalsh/BUILD-11388-fix-pre-commit-config-for-warpbuild-runners

Conversation

@bwalsh434
Copy link
Copy Markdown
Contributor

What Changed?

  • BUILD-11388: Change pre-commit hook to koalaman/shellcheck-precommit which has shellcheck built-in

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 14, 2026

BUILD-11388

@bwalsh434 bwalsh434 marked this pull request as ready for review May 14, 2026 20:54
@bwalsh434 bwalsh434 requested a review from a team as a code owner May 14, 2026 20:54
Copilot AI review requested due to automatic review settings May 14, 2026 20:54
@sonar-review-alpha
Copy link
Copy Markdown
Contributor

sonar-review-alpha Bot commented May 14, 2026

Summary

Switches the shellcheck pre-commit hook from the gruntwork-io wrapper to the official koalaman/shellcheck-precommit hook, which includes shellcheck directly. This simplifies the CI pipeline by using the canonical source rather than a third-party wrapper. Also bumps shellcheck from 0.10.0 to 0.11.0 in mise.toml.

What reviewers should know

Review focus: The hook ID remains shellcheck, so no workflow changes are needed, but verify that:

  • The hook runs successfully in CI with the new configuration
  • The version bump (0.10.0 → 0.11.0) doesn't introduce unexpected linting changes in your builds

For local setup: Developers will need to run pre-commit autoupdate or manually clear their pre-commit cache (rm -rf ~/.cache/pre-commit) to fetch the new hook on their next commit.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s pre-commit configuration to use the upstream koalaman/shellcheck-precommit hook so ShellCheck is provided directly by the hook repo, simplifying local setup and reducing external dependencies.

Changes:

  • Replaced the ShellCheck hook source from gruntwork-io/pre-commit to koalaman/shellcheck-precommit.
  • Pinned the new hook to v0.11.0 (by commit SHA) to keep installs reproducible.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonar-review-alpha[bot]

This comment was marked as resolved.

@bwalsh434 bwalsh434 force-pushed the bugfix/bwalsh/BUILD-11388-fix-pre-commit-config-for-warpbuild-runners branch from f9ff9f3 to 775f665 Compare May 14, 2026 21:12
sonar-review-alpha[bot]

This comment was marked as outdated.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@bwalsh434 bwalsh434 merged commit 27f1126 into master May 15, 2026
18 checks passed
@bwalsh434 bwalsh434 deleted the bugfix/bwalsh/BUILD-11388-fix-pre-commit-config-for-warpbuild-runners branch May 15, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants