Skip to content

BUILD-8724 fix promote action#32

Merged
julien-carsique-sonarsource merged 1 commit intomasterfrom
feat/jcarsique/BUILD-8724-promotePrOption
Aug 1, 2025
Merged

BUILD-8724 fix promote action#32
julien-carsique-sonarsource merged 1 commit intomasterfrom
feat/jcarsique/BUILD-8724-promotePrOption

Conversation

@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource commented Jul 31, 2025

BUILD-8724

Add promote-pull-request option for consistency with build actions
Add missing multi-repo, artifactory-deploy-repo, and artifactory-target-repo missing options for the respective MULTI_REPO_PROMOTE, ARTIFACTORY_DEPLOY_REPO, and ARTIFACTORY_TARGET_REPO environment parameters.

Update README according to BUILD-8686

Tested with:

@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the feat/jcarsique/BUILD-8724-promotePrOption branch 3 times, most recently from 0c950b7 to ea3f9f8 Compare July 31, 2025 15:50
Add promote-pull-request option for consistency with build actions
Add missing multi-repo, artifactory-deploy-repo, and artifactory-target-repo missing options for the respective MULTI_REPO_PROMOTE, ARTIFACTORY_DEPLOY_REPO, and ARTIFACTORY_TARGET_REPO env params
Update README
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the feat/jcarsique/BUILD-8724-promotePrOption branch from ea3f9f8 to 78bbc79 Compare August 1, 2025 07:32
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 1, 2025

🤖 Pull Request summary

Updates promote action to conditionally execute based on pull request deployment setting.

Modified promote action behavior: Added promote-pull-request input (default: false) that controls whether promotion steps execute
Changed build action defaults: Set deploy-pull-request to false for Gradle builds to align with Maven builds
Enhanced promote action inputs: Added multi-repo, artifactory-deploy-repo, and artifactory-target-repo parameters for better configuration control
Updated documentation: Expanded promote action docs with requirements, inputs, and usage examples; improved formatting throughout README

Review focus: The conditional execution logic in promote/action.yml uses if: ${{ inputs.promote-pull-request == 'true' }} on every step - ensure this doesn't break workflows when the input is false, and verify the environment variable assignments handle the conditional logic correctly.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Comment thread promote/action.yml
@julien-carsique-sonarsource julien-carsique-sonarsource merged commit 7a84df9 into master Aug 1, 2025
11 checks passed
@julien-carsique-sonarsource julien-carsique-sonarsource deleted the feat/jcarsique/BUILD-8724-promotePrOption branch August 1, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants