refactor: standardize GitHub Actions with consistent environment handling#34
Conversation
…ling - Standardize PULL_REQUEST environment variable usage across all actions - Add missing PULL_REQUEST_SHA and DEFAULT_BRANCH environment variables - Add repox-url and develocity-url inputs with proper defaults - Remove redundant required: true from parameters with defaults - Update build scripts with standardized helper functions - Improve parameter validation and documentation consistency - Add comprehensive test coverage for untested functions - Update README with latest action configurations and improvements
🤖 Pull Request summaryUpdates build scripts to standardize branch terminology and improve environment variable handling. Main changes: Review focus areas:
|
julien-carsique-sonarsource
left a comment
There was a problem hiding this comment.
GITHUB_SHA, GITHUB_OUTPUT validation is missing
ARTIFACTORY_ACCESS_TOKEN, GITHUB_EVENT_NAME, MAVEN_LOCAL_REPOSITORY description is missing
seems that MAVEN_LOCAL_REPOSITORY is missing an export, for the case when it's set with a default value



Summary
This PR standardizes all GitHub Actions build scripts with consistent environment variable handling, improved parameter validation, and comprehensive documentation.
Key Changes
🔄 Environment Variable Standardization
PULL_REQUESTenvironment variable format across all actions:${{ github.event.pull_request.number || '' }}PULL_REQUEST_SHAandDEFAULT_BRANCHenvironment variables to all build actions⚙️ Action Configuration Improvements
repox-urlinput parameter to all build actions (default:https://repox.jfrog.io)develocity-urlinput parameter to Maven builds (default:https://develocity.sonar.build/)required: truefrom parameters with default values (GitHub Actions best practice)🔍 Parameter Validation & Documentation
"${VAR:?}"syntax across all build scripts🧪 Test Coverage & Quality
📚 Documentation Updates
Test Results
All build actions tested successfully:
Back to 100% coverage - added missing tests for Poetry and Gradle.
Breaking Changes
None - all changes are backward compatible with existing workflows.
Migration Guide
No migration required. Existing workflows will continue to work with the new defaults.