Skip to content

BUILD-8678: update README.md and fix typos#40

Merged
hedinasr merged 5 commits intomasterfrom
feat/hnasr/BUILD-8678-updateDocumentation
Aug 5, 2025
Merged

BUILD-8678: update README.md and fix typos#40
hedinasr merged 5 commits intomasterfrom
feat/hnasr/BUILD-8678-updateDocumentation

Conversation

@hedinasr
Copy link
Copy Markdown
Contributor

@hedinasr hedinasr commented Aug 5, 2025

@hedinasr hedinasr marked this pull request as ready for review August 5, 2025 06:37
@hedinasr hedinasr requested a review from a team August 5, 2025 06:37
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

Let's be consistent with what we've included in cursor rules

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

Also - can you share URL to build actions executions with this build number removed?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 5, 2025

🤖 Pull Request summary

Updates GitHub Actions workflow configuration and removes unused step IDs.

• Removes unnecessary get-build-number steps from build workflows in README examples
• Replaces get-build-number with actions/checkout@v4.2.2 in Poetry, Gradle, NPM, and Yarn workflows
• Removes unused id: build-number from all build action definitions
• Adds missing get-build-number step to promote action

Review focus: Verify that removing the build-number IDs doesn't break any step references in the actual workflow logic.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hedinasr
Copy link
Copy Markdown
Contributor Author

hedinasr commented Aug 5, 2025

Also - can you share URL to build actions executions with this build number removed?

Here is build from yesterday SonarSource/sonar-dummy-gradle-oss#265. cc @mikolaj-matuszny-ext-sonarsource

hedinasr and others added 5 commits August 5, 2025 11:16
Co-authored-by: mikolaj-matuszny-ext-sonarsource <mikolaj.matuszny.ext@sonarsource.com>
Co-authored-by: mikolaj-matuszny-ext-sonarsource <mikolaj.matuszny.ext@sonarsource.com>
Co-authored-by: mikolaj-matuszny-ext-sonarsource <mikolaj.matuszny.ext@sonarsource.com>
Co-authored-by: mikolaj-matuszny-ext-sonarsource <mikolaj.matuszny.ext@sonarsource.com>
@hedinasr hedinasr force-pushed the feat/hnasr/BUILD-8678-updateDocumentation branch from 67844de to a3709dc Compare August 5, 2025 09:16
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 5, 2025

🤖 Pull Request summary

Updates build step configuration and README examples for CI workflows.

• Removes unused id: build-number from all build action files (gradle, maven, npm, poetry, yarn)
• Adds missing get-build-number step to the promote action
• Updates README examples to replace get-build-number calls with actions/checkout@v4.2.2 for most build jobs
• Removes redundant get-build-number steps from some README workflow examples

Review focus: Verify that removing the build-number ID references doesn't break any downstream steps that might reference steps.build-number.outputs.*

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hedinasr hedinasr merged commit a1d85e9 into master Aug 5, 2025
8 checks passed
@hedinasr hedinasr deleted the feat/hnasr/BUILD-8678-updateDocumentation branch August 5, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants