BUILD-8568: Fix maven windows build#44
Conversation
d9baa88 to
c9afb5d
Compare
c9afb5d to
cba7eb0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Maven build issues on Windows by handling path format differences between Unix-style and Windows paths. The changes ensure that Maven settings paths are properly converted for Windows environments and standardize Maven command flags for better cross-platform compatibility.
- Adds Windows-specific path conversion logic using
cygpathfor Maven settings - Updates all Maven commands to use the resolved settings path
- Standardizes Maven command flags with explicit long-form options
- Sets the Maven settings environment variable in the GitHub Action
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build-maven/build.sh | Implements Windows path conversion logic and updates Maven commands to use resolved settings path |
| build-maven/action.yml | Sets the MAVEN_SETTINGS environment variable to ensure proper settings file location |
df04650 to
8c558e7
Compare
Signed-off-by: Jayadeep Kinavoor Madam <jayadeep.kinavoormadam@sonarsource.com>
8c558e7 to
e5b2aae
Compare
🤖 Pull Request summaryUpdates Maven configuration to use custom settings and improve cross-platform compatibility. • Exports MAVEN_SETTINGS environment variable pointing to Maven config settings.xml Focus areas for review: Windows path conversion logic and ensure all Maven invocations consistently use the settings file.
|



BUILD-8568
BUILD-8568: Fix maven build on windows
tested in https://github.com/SonarSource/sonar-dummy/pull/476