Skip to content

BUILD-8568: Fix maven windows build#44

Merged
jayadeep-km-sonarsource merged 1 commit intomasterfrom
feat/jd/BUILD-8568-windows-build-maven
Aug 8, 2025
Merged

BUILD-8568: Fix maven windows build#44
jayadeep-km-sonarsource merged 1 commit intomasterfrom
feat/jd/BUILD-8568-windows-build-maven

Conversation

@jayadeep-km-sonarsource
Copy link
Copy Markdown
Contributor

@jayadeep-km-sonarsource jayadeep-km-sonarsource commented Aug 7, 2025

@jayadeep-km-sonarsource jayadeep-km-sonarsource force-pushed the feat/jd/BUILD-8568-windows-build-maven branch 4 times, most recently from d9baa88 to c9afb5d Compare August 7, 2025 09:53
@jayadeep-km-sonarsource jayadeep-km-sonarsource changed the title BUILD-8568: Debug windows build BUILD-8568: Fix maven windows build Aug 7, 2025
@jayadeep-km-sonarsource jayadeep-km-sonarsource force-pushed the feat/jd/BUILD-8568-windows-build-maven branch from c9afb5d to cba7eb0 Compare August 7, 2025 12:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Maven build issues on Windows by handling path format differences between Unix-style and Windows paths. The changes ensure that Maven settings paths are properly converted for Windows environments and standardize Maven command flags for better cross-platform compatibility.

  • Adds Windows-specific path conversion logic using cygpath for Maven settings
  • Updates all Maven commands to use the resolved settings path
  • Standardizes Maven command flags with explicit long-form options
  • Sets the Maven settings environment variable in the GitHub Action

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
build-maven/build.sh Implements Windows path conversion logic and updates Maven commands to use resolved settings path
build-maven/action.yml Sets the MAVEN_SETTINGS environment variable to ensure proper settings file location

Comment thread build-maven/build.sh Outdated
Comment thread build-maven/build.sh
@jayadeep-km-sonarsource jayadeep-km-sonarsource force-pushed the feat/jd/BUILD-8568-windows-build-maven branch 5 times, most recently from df04650 to 8c558e7 Compare August 7, 2025 14:53
@jayadeep-km-sonarsource jayadeep-km-sonarsource marked this pull request as ready for review August 7, 2025 14:53
@jayadeep-km-sonarsource jayadeep-km-sonarsource requested a review from a team August 7, 2025 14:53
Signed-off-by: Jayadeep Kinavoor Madam <jayadeep.kinavoormadam@sonarsource.com>
@jayadeep-km-sonarsource jayadeep-km-sonarsource force-pushed the feat/jd/BUILD-8568-windows-build-maven branch from 8c558e7 to e5b2aae Compare August 7, 2025 14:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 7, 2025

🤖 Pull Request summary

Updates Maven configuration to use custom settings and improve cross-platform compatibility.

• Exports MAVEN_SETTINGS environment variable pointing to Maven config settings.xml
• Adds Windows path conversion using cygpath for proper Maven settings path handling
• Updates all Maven commands to use --settings flag with the custom settings file
• Modernizes Maven CLI flags (replaces -B with --batch-mode, adds --no-transfer-progress, etc.)
• Updates tests to verify Maven commands include the settings parameter

Focus areas for review: Windows path conversion logic and ensure all Maven invocations consistently use the settings file.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jayadeep-km-sonarsource jayadeep-km-sonarsource merged commit c862437 into master Aug 8, 2025
9 checks passed
@jayadeep-km-sonarsource jayadeep-km-sonarsource deleted the feat/jd/BUILD-8568-windows-build-maven branch August 8, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants