Skip to content

BUILD-8842 Use the gradle-wrapper by default#52

Merged
matemoln merged 2 commits intomasterfrom
feat/mm/fix-gradle-usage
Aug 13, 2025
Merged

BUILD-8842 Use the gradle-wrapper by default#52
matemoln merged 2 commits intomasterfrom
feat/mm/fix-gradle-usage

Conversation

@matemoln
Copy link
Copy Markdown
Contributor

@matemoln matemoln commented Aug 13, 2025

BUILD-8842

  • Use the gradle wrapper (./gradlew) by default and fall back to the gradle binary in case it is not found.
  • Remove unused parameter gradle-wrapper-validation
  • Remove gradle-version parameter to set conventions on the wrapper

@matemoln matemoln requested a review from a team August 13, 2025 12:47
@matemoln matemoln force-pushed the feat/mm/fix-gradle-usage branch 3 times, most recently from e3469f2 to 4fb4530 Compare August 13, 2025 13:28
@matemoln matemoln force-pushed the feat/mm/fix-gradle-usage branch from 4fb4530 to c6858f9 Compare August 13, 2025 14:14
@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

Can you edit line 256 in README.md to change information about Gradle setup?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify README.md

@matemoln matemoln force-pushed the feat/mm/fix-gradle-usage branch from a147c5e to 38741a1 Compare August 13, 2025 14:54
@matemoln matemoln enabled auto-merge (squash) August 13, 2025 14:55
@matemoln matemoln changed the title BUILD-8842 Default gradle command to the wrapper BUILD-8842 Use the gradle-wrapper by default Aug 13, 2025
@matemoln matemoln disabled auto-merge August 13, 2025 14:55
@matemoln matemoln enabled auto-merge (squash) August 13, 2025 14:55
@matemoln matemoln merged commit 5a24f21 into master Aug 13, 2025
8 checks passed
@matemoln matemoln deleted the feat/mm/fix-gradle-usage branch August 13, 2025 14:56
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Updates Gradle build action to use wrapper-first approach and removes deprecated options.

Removed deprecated inputs: Eliminated gradle-version and gradle-wrapper-validation parameters from action interface
Modified Gradle detection logic: Now prioritizes ./gradlew over system gradle command with proper fallback handling
Updated documentation: Clarified Java/Gradle installation requirements and added table of contents to README
Enhanced error handling: Added explicit failure when neither Gradle wrapper nor system Gradle are available

Review focus: The set_gradle_cmd() function logic change is critical - verify the wrapper detection and fallback behavior works correctly across different project setups.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants