Skip to content

BUILD-8718: Shadow scans suport in maven#53

Merged
mikolaj-matuszny-ext-sonarsource merged 6 commits intomasterfrom
feat/jd/BUILD-8718-dogfooding-maven
Aug 20, 2025
Merged

BUILD-8718: Shadow scans suport in maven#53
mikolaj-matuszny-ext-sonarsource merged 6 commits intomasterfrom
feat/jd/BUILD-8718-dogfooding-maven

Conversation

@jayadeep-km-sonarsource
Copy link
Copy Markdown
Contributor

@jayadeep-km-sonarsource jayadeep-km-sonarsource commented Aug 13, 2025

BUILD-8718

BUILD-8718: Shadow scans suport in maven

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/jd/BUILD-8718-dogfooding-maven branch from 38f7215 to f121e9e Compare August 15, 2025 11:25
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource marked this pull request as ready for review August 15, 2025 13:16
@SamirM-BE
Copy link
Copy Markdown
Contributor

LGTM, my recommendation is to extract the sonar functions in a different file to be able to re-use them for other actions.

Comment thread build-maven/action.yml Outdated
Comment thread spec/build-maven_spec.sh Outdated
Comment thread build-maven/build.sh Outdated
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

This pull request adds support for running SonarQube analysis on multiple platforms (shadow scans).

New feature: Added run-shadow-scans parameter to enable analysis across all SonarQube platforms (next, sqc-eu, sqc-us) instead of just the selected one
Credential management: Refactored to fetch tokens for all three platforms from Vault instead of dynamically selecting one
Build script changes: Separated Maven build execution from SonarQube analysis, with conditional deployment disabling during shadow scans
Shared utilities: Created new common-functions.sh with reusable functions for platform configuration and multi-platform analysis coordination
Test coverage: Updated test suite to cover new functionality including platform switching and shadow scan behavior

Review focus: The credential exposure in the action.yml file now retrieves tokens for all platforms regardless of usage, and the deployment disabling logic in build.sh uses string manipulation that should be validated for edge cases.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource merged commit b323b24 into master Aug 20, 2025
8 checks passed
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource deleted the feat/jd/BUILD-8718-dogfooding-maven branch August 20, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants