Skip to content

BUILD-8865 Fix missing artifactory tokens expected in sonarqube-mcp-server#54

Merged
matemoln merged 1 commit intomasterfrom
fix/mm/BUILD-8865
Aug 14, 2025
Merged

BUILD-8865 Fix missing artifactory tokens expected in sonarqube-mcp-server#54
matemoln merged 1 commit intomasterfrom
fix/mm/BUILD-8865

Conversation

@matemoln
Copy link
Copy Markdown
Contributor

@matemoln matemoln commented Aug 14, 2025

@matemoln matemoln requested a review from a team August 14, 2025 10:06
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Adds Artifactory reader credentials to the Gradle build action.

• Retrieves reader username and access token from Vault alongside existing deployer credentials
• Exposes reader credentials as ARTIFACTORY_PRIVATE_USERNAME and ARTIFACTORY_PRIVATE_PASSWORD environment variables

Review focus: The environment variable mapping appears incorrect - USERNAME is mapped to PASSWORD and vice versa. This credential swap needs verification and likely correction.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matemoln matemoln merged commit 04b3c3e into master Aug 14, 2025
9 checks passed
@matemoln matemoln deleted the fix/mm/BUILD-8865 branch August 14, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants