Skip to content

BUILD-8855 promote improvement#65

Merged
mikolaj-matuszny-ext-sonarsource merged 2 commits intomasterfrom
feat/mmatuszny/BUILD-8855-promote-improvement
Aug 25, 2025
Merged

BUILD-8855 promote improvement#65
mikolaj-matuszny-ext-sonarsource merged 2 commits intomasterfrom
feat/mmatuszny/BUILD-8855-promote-improvement

Conversation

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource commented Aug 25, 2025

Fix the bug of promote action not running when promote-pull-request was set to false.

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8855-promote-improvement branch 4 times, most recently from 149a376 to 7965814 Compare August 25, 2025 11:53
@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor Author

https://github.com/SonarSource/sonar-dummy-js/actions/runs/17208109694/job/48813201106 - working as expected
I've decided to keep mise as public runners do not have jf installed and will cause the action to fail.

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource marked this pull request as ready for review August 25, 2025 12:03
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8855-promote-improvement branch from 7965814 to b3b4d27 Compare August 25, 2025 12:03
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Refactors promotion logic to make PR promotion conditional based on input parameter.

• Removes conditional steps in GitHub Action and makes them always run
• Adds PROMOTE_PULL_REQUEST environment variable to control promotion behavior
• Updates promotion script to check flag and skip PR promotion when disabled
• Removes unused tools from mise configuration (gh, jq)
• Adds tests for new PR promotion toggle functionality

Review focus: Verify the logic change properly handles the promotion flow - ensure PRs are correctly skipped when the flag is false, and that removing the GitHub Action conditionals doesn't break existing workflows.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource merged commit 60d826b into master Aug 25, 2025
9 checks passed
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource deleted the feat/mmatuszny/BUILD-8855-promote-improvement branch August 25, 2025 17:30
matemoln pushed a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants