Skip to content

BUILD-8811 Make ARTIFACTORY_URL path configurable#68

Merged
mikolaj-matuszny-ext-sonarsource merged 1 commit intomasterfrom
feat/mmatuszny/8811-artifactory-url
Aug 29, 2025
Merged

BUILD-8811 Make ARTIFACTORY_URL path configurable#68
mikolaj-matuszny-ext-sonarsource merged 1 commit intomasterfrom
feat/mmatuszny/8811-artifactory-url

Conversation

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource commented Aug 27, 2025

Adds optional repox-artifactory-url parameter to override default Artifactory URL construction.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue addressed by the PR is to allow the use of https://repox.jfrog.io/repox ? Is that correct?
This old redirect was weird and generates some bugs. Its usage is deprecated. So I would tend to provide a solution for backward compliance, considering that this should not be needed in the future.

Is it possible to add an input instead?

There is a confusion with the "Repox" naming and "Artifactory" vs "Platform".
Here are the URLs that can be needed:

For configuration, it may be necessary to use the platform URL rather than the Artifactory URL.

To lower the confusion and fix errors, we have introduced those naming in the vault:

url=https://repox.jfrog.io/repox is a legacy value
platform_url and artifactory_url were added for clarification

In the context of this PR, here's a suggestion:

  • keep repox-url unchanged, it is the platform URL
  • add an optional repox-artifactory-url to override the default ARTIFACTORY_URL if needed

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/8811-artifactory-url branch 3 times, most recently from d8a3fc7 to 707b4af Compare August 29, 2025 11:23
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/8811-artifactory-url branch from 707b4af to 5abd8e9 Compare August 29, 2025 12:15
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/8811-artifactory-url branch from 5abd8e9 to cccfffb Compare August 29, 2025 12:18
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Summary: Adds configurable Repox Artifactory API URL support across all build actions.

Changes:
• Added repox-artifactory-url optional input parameter to all 5 build actions (gradle, maven, npm, poetry, yarn)
• Updated documentation tables in README.md to include the new parameter with consistent descriptions
• Modified ARTIFACTORY_URL environment variable logic to use the new parameter when provided, falling back to the constructed repox-url/artifactory format

Review focus:
The conditional logic for ARTIFACTORY_URL construction uses GitHub Actions expressions - verify the syntax is correct and test with both empty and populated repox-artifactory-url values.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource merged commit 5c0d0ff into master Aug 29, 2025
9 checks passed
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource deleted the feat/mmatuszny/8811-artifactory-url branch August 29, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants