BUILD-8811 Make ARTIFACTORY_URL path configurable#68
Conversation
julien-carsique-sonarsource
left a comment
There was a problem hiding this comment.
The issue addressed by the PR is to allow the use of https://repox.jfrog.io/repox ? Is that correct?
This old redirect was weird and generates some bugs. Its usage is deprecated. So I would tend to provide a solution for backward compliance, considering that this should not be needed in the future.
Is it possible to add an input instead?
There is a confusion with the "Repox" naming and "Artifactory" vs "Platform".
Here are the URLs that can be needed:
- JFrog Platform URL: https://repox.jfrog.io/
- Artifactory URL: https://repox.jfrog.io/artifactory/
- Distribution URL: https://repox.jfrog.io/distribution/
- Xray URL: https://repox.jfrog.io/xray/
- Mission Control URL: https://repox.jfrog.io/mc/
- Pipelines URL: https://repox.jfrog.io/pipelines/
For configuration, it may be necessary to use the platform URL rather than the Artifactory URL.
To lower the confusion and fix errors, we have introduced those naming in the vault:
- artifactory_url https://repox.jfrog.io/artifactory
- platform_url https://repox.jfrog.io
- url https://repox.jfrog.io/repox
url=https://repox.jfrog.io/repox is a legacy value
platform_url and artifactory_url were added for clarification
In the context of this PR, here's a suggestion:
- keep repox-url unchanged, it is the platform URL
- add an optional repox-artifactory-url to override the default ARTIFACTORY_URL if needed
d8a3fc7 to
707b4af
Compare
707b4af to
5abd8e9
Compare
5abd8e9 to
cccfffb
Compare
🤖 Pull Request summarySummary: Adds configurable Repox Artifactory API URL support across all build actions. Changes: Review focus:
|



Adds optional repox-artifactory-url parameter to override default Artifactory URL construction.