Skip to content

BUILD-8999: fix JGit blobless cloning#79

Merged
hedinasr merged 2 commits intomasterfrom
fix/hnasr/BUILD-8999-fixGitFetchUnshallow
Sep 5, 2025
Merged

BUILD-8999: fix JGit blobless cloning#79
hedinasr merged 2 commits intomasterfrom
fix/hnasr/BUILD-8999-fixGitFetchUnshallow

Conversation

@hedinasr
Copy link
Copy Markdown
Contributor

@hedinasr hedinasr commented Sep 3, 2025

@hedinasr hedinasr force-pushed the fix/hnasr/BUILD-8999-fixGitFetchUnshallow branch from 7b9d010 to 1320060 Compare September 3, 2025 12:52
@hedinasr hedinasr marked this pull request as ready for review September 3, 2025 12:56
@hedinasr hedinasr requested a review from a team September 3, 2025 12:56
@hedinasr hedinasr self-assigned this Sep 3, 2025
@hedinasr hedinasr marked this pull request as draft September 3, 2025 13:18
Copy link
Copy Markdown
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unshallow is needed.
Only removing --filter=blob:none should work according to your comments on the Jira ticket. This filter is only an optimization to speed the download time.

@hedinasr hedinasr force-pushed the fix/hnasr/BUILD-8999-fixGitFetchUnshallow branch from a940d0b to 7d22b8e Compare September 5, 2025 07:06
@hedinasr
Copy link
Copy Markdown
Contributor Author

hedinasr commented Sep 5, 2025

Unshallow is needed. Only removing --filter=blob:none should work according to your comments on the Jira ticket. This filter is only an optimization to speed the download time.

I don't see why we need unshallow. I have ran a test against this PR here https://github.com/SonarSource/ops-releasability/actions/runs/17458692819/job/49578097952?pr=473 and it working fine.

@hedinasr hedinasr force-pushed the fix/hnasr/BUILD-8999-fixGitFetchUnshallow branch from 7d22b8e to fef0d80 Compare September 5, 2025 07:07
@hedinasr hedinasr changed the title BUILD-8999: add --no-filter to git fetch command BUILD-8999: fix JGit blobless cloning Sep 5, 2025
@hedinasr hedinasr force-pushed the fix/hnasr/BUILD-8999-fixGitFetchUnshallow branch 5 times, most recently from 149eff1 to d781372 Compare September 5, 2025 08:21
@hedinasr hedinasr marked this pull request as ready for review September 5, 2025 08:22
@hedinasr hedinasr force-pushed the fix/hnasr/BUILD-8999-fixGitFetchUnshallow branch from d781372 to c75d74d Compare September 5, 2025 09:22
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 5, 2025

🤖 Pull Request summary

Removes --filter=blob:none flag from git fetch operations across build scripts.

• Modifies git_fetch_unshallow() function in Maven, npm, Poetry, and Yarn build scripts
• Updates corresponding unit tests to match the new git fetch commands
• Adds missing function comment in Poetry build script

Review focus: Consider the performance impact of removing the blob filter - this will now download full git objects instead of just references, potentially increasing build times and network usage.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hedinasr hedinasr merged commit 737dccc into master Sep 5, 2025
10 checks passed
@hedinasr hedinasr deleted the fix/hnasr/BUILD-8999-fixGitFetchUnshallow branch September 5, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants