Skip to content

PREQ-2006 build-npm: repox auth and default ARTIFACTORY_DEPLOY_REPO#86

Merged
julien-carsique-sonarsource merged 1 commit intomasterfrom
fix/jcarsique/PREQ-2006-buildNpmAuth
Sep 12, 2025
Merged

PREQ-2006 build-npm: repox auth and default ARTIFACTORY_DEPLOY_REPO#86
julien-carsique-sonarsource merged 1 commit intomasterfrom
fix/jcarsique/PREQ-2006-buildNpmAuth

Conversation

@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource commented Sep 10, 2025

PREQ-2006

Set Repox as the default registry and authenticate.
Fix "npm ci" command which was not authenticated.
Remove unused input artifactory-deploy-access-token
Add default value for ARTIFACTORY_DEPLOY_REPO

Tested with

@julien-carsique-sonarsource julien-carsique-sonarsource requested a review from a team September 10, 2025 09:56
@julien-carsique-sonarsource julien-carsique-sonarsource marked this pull request as draft September 10, 2025 09:57
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/PREQ-2006-buildNpmAuth branch 5 times, most recently from 520efb0 to 0ff53e6 Compare September 11, 2025 13:54
@julien-carsique-sonarsource julien-carsique-sonarsource marked this pull request as ready for review September 11, 2025 14:03
authenticate with Repox for "npm ci" command
remove unused input artifactory-deploy-access-token
add default value for ARTIFACTORY_DEPLOY_REPO
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Removes Artifactory access token parameter and improves repository configuration.

• Removes artifactory-deploy-access-token input parameter and documentation references
• Adds auto-detection for artifactory-deploy-repo based on repository visibility
• Consolidates JFrog configuration setup in both NPM and Yarn build scripts
• Adds NPM logs archival on build failures
• Removes obsolete validation tests for missing Artifactory credentials

Focus areas for review:

  • Verify the auto-detection logic for deployment repository names matches expected conventions
  • Confirm the consolidated JFrog setup doesn't break existing authentication flows
  • Test that the new logs archival works correctly on failure scenarios

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@julien-carsique-sonarsource julien-carsique-sonarsource merged commit 0d5935b into master Sep 12, 2025
11 checks passed
@julien-carsique-sonarsource julien-carsique-sonarsource deleted the fix/jcarsique/PREQ-2006-buildNpmAuth branch September 12, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants