Skip to content

BUILD-8830 disable sonar scans for build-npm option#97

Merged
mikolaj-matuszny-ext-sonarsource merged 1 commit intomasterfrom
feat/mmatuszny/BUILD-8830-disable-sonar-npm
Sep 18, 2025
Merged

BUILD-8830 disable sonar scans for build-npm option#97
mikolaj-matuszny-ext-sonarsource merged 1 commit intomasterfrom
feat/mmatuszny/BUILD-8830-disable-sonar-npm

Conversation

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource commented Sep 18, 2025

@mikolaj-matuszny-ext-sonarsource
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99.78% coverage, you may want to add a test

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8830-disable-sonar-npm branch from b0cac75 to d573bd0 Compare September 18, 2025 12:26
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource force-pushed the feat/mmatuszny/BUILD-8830-disable-sonar-npm branch from d573bd0 to ded5bfa Compare September 18, 2025 12:30
@sonarqubecloud
Copy link
Copy Markdown

🤖 Pull Request summary

Adds support for disabling SonarQube analysis in build-npm action.

• Added "none" option to sonar-platform parameter to skip all sonar scans
• Modified validation to skip SonarQube URL/token checks when platform is "none"
• Updated git_fetch_unshallow() to skip unnecessary git operations when sonar is disabled
• Added test coverage for the new "none" platform behavior

Review focus: Ensure the conditional logic properly handles all sonar-related operations when disabled.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource merged commit caa7b28 into master Sep 18, 2025
11 checks passed
@mikolaj-matuszny-ext-sonarsource mikolaj-matuszny-ext-sonarsource deleted the feat/mmatuszny/BUILD-8830-disable-sonar-npm branch September 18, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants