ECHOES-1188 Allow custom icon (or no icon) for DropdownMenu.ItemLinkDownload

[david-cho-lerat-sonarsource]

No description provided.

[netlify]

✅ Deploy Preview for echoes-react ready!

Name	Link
🔨 Latest commit	b027107
🔍 Latest deploy log	https://app.netlify.com/projects/echoes-react/deploys/69de0c34c874020008829068
😎 Deploy Preview	https://deploy-preview-668--echoes-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hashicorp-vault-sonar-prod]

ECHOES-1188

[sonar-review-alpha]

Summary

This PR makes the download icon in DropdownMenu.ItemLinkDownload customizable. Previously the component always rendered with a hardcoded download icon. Now consumers can:

• Accept the default download icon (current behavior)
• Provide a custom icon via the prefix prop
• Render with no icon by passing prefix={undefined}

The implementation removes 'prefix' from the prop omission list and uses a conditional to apply the default icon only when prefix isn't explicitly provided.

What reviewers should know

Key changes:

• DropdownMenuItemLinkDownloadProps type: prefix moved from omitted props to accepted props
• Component logic: Now checks if prefix exists in props; uses default IconDownload if not provided
• Test coverage: New test validates all three scenarios (default icon, custom icon, no icon)
• Storybook: Two new stories demonstrate the customization options

For reviewers:
Start with DropdownMenuItemLinkDownload.tsx (the logic is straightforward). The test comprehensively covers the feature. The Storybook stories provide visual reference for the new behavior. Note that passing prefix={undefined} explicitly removes the icon—this is intentional and tested.

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[sonar-review-alpha]

LGTM! ✅

Clean, minimal change. The 'prefix' in props check is the correct idiom for distinguishing "prop not passed" from "prop explicitly set to undefined", and the spread-then-override pattern in the JSX is safe. Test coverage is thorough across all three cases.

🗣️ Give feedback

[jeremy-davis-sonarsource]

Noice