ECHOES-1280 Fix architecture issue ("common" depending on "components")

[david-cho-lerat-sonarsource]

ECHOES-1280

[netlify]

✅ Deploy Preview for echoes-react ready!

Name	Link
🔨 Latest commit	045237a
🔍 Latest deploy log	https://app.netlify.com/projects/echoes-react/deploys/69e0ef5ef59d4f000879b730
😎 Deploy Preview	https://deploy-preview-670--echoes-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hashicorp-vault-sonar-prod]

ECHOES-1280

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[sonar-review-alpha]

Summary

This PR fixes an architectural layering issue where src/common/components/PromotedSectionStyles.tsx was importing from src/components/badges, causing the lower-level "common" module to depend on the higher-level "components" module.

The fix moves the BADGE_VARIETIES constant from the common layer to src/components/promoted-section/PromotedSection.tsx where it's actually used, along with its direct import of BadgeVariety. This restores proper module layering: only "components" depends on "common", not the reverse.

What reviewers should know

What changed:

• Removed BADGE_VARIETIES and the cross-layer import from PromotedSectionStyles.tsx
• Added BADGE_VARIETIES as a local constant in PromotedSection.tsx where it's consumed
• Updated imports in PromotedSection.tsx to get BadgeVariety directly from ../badges

Why it matters: This prevents "common" from depending on "components", keeping architectural boundaries clean. The constant is only used in PromotedSection, so colocating it there is more appropriate.

To review: Check that the moved constant still has the same values and behavior in its new location, and verify that the BadgeVariety import works correctly.

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[sonar-review-alpha]

LGTM! ✅

Clean, minimal fix with no issues to flag. The refactor correctly moves BADGE_VARIETIES from the shared common layer to its only consumer, and the addition of as const on the moved constant is a small improvement over the original.

🗣️ Give feedback