GHA-280 Accept Slack Channel IDs (not add "#" in front of them).

[Krosovok]

Add a regexp validation for Slack channel id format to avoid adding # in front of them. It wouldn't break existing logic with the exception of an edge case when someone explicitly names a channel something like "C1234ABCD" AND passes it without #, which is not very likely based on company convention.

[sonar-review-alpha]

Summary

This PR extends the Slack channel input to accept both channel names (e.g., releases) and channel IDs (e.g., C1234ABCDE). The change adds a regex validation in normalize_channel() that detects Slack channel IDs (format: [CDG][A-Z0-9]{8,10}) and passes them through unchanged, rather than prefixing them with #. Channel names continue to work as before. Documentation has been updated to reflect this new capability.

What reviewers should know

Key change: Look at notify_slack.py — the regex pattern _CHANNEL_ID_RE and the updated normalize_channel() function determine how inputs are classified. The pattern is deliberately narrow ([CDG] prefix, 8-10 alphanumeric suffix) to avoid false positives.

Edge case to be aware of: If someone manually names a Slack channel something like "C1234ABCD" (matching the channel ID format) AND passes it without #, it will now be treated as a channel ID and won't get the # prefix. The author notes this is unlikely given typical naming conventions. Worth considering if your organization has any such channels.

Tests to review: The new test cases in test_notify_slack.py cover the three channel ID types (C, D, G) and various ID lengths — good coverage for the regex boundary conditions (8-10 chars after the prefix).

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[hashicorp-vault-sonar-prod]

GHA-280

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nils-werner-sonarsource]

LGTM