GHA-283 Make new-version optional by default#143
GHA-283 Make new-version optional by default#143nils-werner-sonarsource merged 2 commits intomasterfrom
new-version optional by default#143Conversation
new-version optional by defaultnew-version optional by default
SummaryThis PR makes the The PR also improves the What reviewers should knowStart with: Watch for: The incomplete author description ("Part of ") suggests this might be part of a larger effort. Verify this change doesn't break existing callers that rely on the validation, and check if the workflow has a fallback mechanism when the version isn't manually specified. notify-slack changes: The channel ID support is a pure enhancement. The regex
|
|
There was a problem hiding this comment.
The change is safe and intentional. When new-version is omitted, it flows as an empty string into create-jira-version's jira-new-version-name input, which already handles the empty case by auto-incrementing the minor version (see create-jira-version/action.yml lines 53–78). The summary step at line 542 already has the || 'not specified, autoincrement minor version' fallback, confirming this behavior was pre-planned.
One thing worth a quick confirmation: cloud-security-automated-release.yml (line 71–72) and abd-automated-release.yml (line 70–72) both still declare new-version as required: true. If the intent of the larger effort is to make auto-increment the default across all release workflows, those two will need the same update. If they're intentionally excluded for now that's fine, but it's worth noting the inconsistency so callers aren't surprised.



Part of