GHA-300 Automated release workflow should use new plugin deployment workflow#152
Conversation
SummaryWhat: Adds a new Why: During the transition to sonar-plugins-deployer, release automation needs to update plugin versions in two places simultaneously. The action handles YAML anchor updates (not direct version fields), which allows all alias references in the Scope: The new feature is opt-in — the What reviewers should knowStart here:
Key design decisions to verify:
Watch for:
|
e1228d3 to
dd57ed8
Compare
c650aa2 to
e50de30
Compare
…orkflow When sqc-integration is true and sqc-plugins-deployer-integration is true, the automated release opens PRs in both sonarcloud-core (existing) and sonar-plugins-deployer (new). The deployer PR is opt-in (default false) during the transition period. - New update-plugins-deployer action: sparse-checks out plugins.yaml, computes anchor key from plugin-name (strips -enterprise, maps csharp/vbnet → dotnet), updates the version anchor in the versions: block with sed, fails hard if the anchor is not found, creates a draft-aware PR with the standard branch naming - New sqc-plugins-deployer-integration input on automated-release.yml (default false) - New plugins-deployer-pull-request-url output - unit-tests job: bash test script covering all key-mapping cases - action-tests job: ticket validation + fixture-based update tests for java, security (with frontends), go-enterprise, dotnet-enterprise Prerequisites: - re-terraform-aws-vault PR #9142: sonar-plugins-deployer added to release-automation secrets - sonar-plugins-deployer PR #41: YAML anchors added to versions: block for all plugins
cd04e44 to
3d4d375
Compare
Co-authored-by: sonar-review-alpha[bot] <266116024+sonar-review-alpha[bot]@users.noreply.github.com>
yasen-pavlov-sonarsource
left a comment
There was a problem hiding this comment.
LGTM! Left one comment regarding the plugin-artifacts input.
There was a problem hiding this comment.
The incremental diff is a clean, focused removal of the plugin-artifacts input — the README, action.yml, test workflow, and script comment are all updated consistently. One stale comment slipped through, and the ticket-validation test coverage concern from the previous review remains unaddressed.
Co-authored-by: sonar-review-alpha[bot] <266116024+sonar-review-alpha[bot]@users.noreply.github.com>
|



Summary
When `sqc-integration: true` and `sqc-plugins-deployer-integration: true`, the automated release opens PRs in both repositories simultaneously during the transition period:
The `sqc-plugins-deployer-integration` input defaults to `false` so existing callers are unaffected until they opt in.
Changes
Artifact → anchor key mapping
`plugin-artifacts-sqc` value → anchor in `versions:` block:
Test strategy
Automated tests (CI)
End-to-end test (manual, completed)
A full draft release was triggered from SonarSource/sonar-php using a test branch (`nw/test-plugins-deployer-release`) pointing at this PR's branch with `sqc-plugins-deployer-integration: true`, `is-draft-release: true`, and `use-jira-sandbox: true`.
Result: sonar-plugins-deployer#46 was created as a draft with the correct diff — only the `sonar-php: &version-sonar-php` anchor line updated, all alias references untouched. The PR was closed after verification.
Prerequisites (separate PRs)
🤖 Generated with Claude Code