You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extracts the hardcoded maven-bundle-plugin version (2.3.7) into a Maven property in the guava project's pom.xml. This allows the plugin version to be overridden at build time (e.g., via parent POMs, profiles, or CLI parameters) while maintaining the same default behavior.
The change is minimal and non-functional — the plugin continues to use version 2.3.7, but now through a property reference instead of a hardcoded value. This is a Maven best practice for plugin management.
What reviewers should know
What to look for:
Single file change: guava/pom.xml
Two modifications:
New property maven-bundle-plugin.version added to <properties>
Plugin <version> element updated to reference the property
Context:
The change addresses SONARJAVA-6235, which likely flags hardcoded plugin versions as a code quality issue. Extracting to a property is the standard Maven solution.
Risk assessment:
Minimal. This is a build configuration change with no impact on runtime behavior. The plugin version remains 2.3.7; only how it's specified changes. If other POM files (parent POMs, profiles) rely on overriding this version, they can now do so — verify this aligns with your build setup if version overrides are used elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.