Skip to content

SONARJAVA-6235 Explicitely declare maven-bundle-plugin version to enable overriding#10

Merged
tomasz-tylenda-sonarsource merged 1 commit intomasterfrom
tt/orchestrator-version
Apr 10, 2026
Merged

SONARJAVA-6235 Explicitely declare maven-bundle-plugin version to enable overriding#10
tomasz-tylenda-sonarsource merged 1 commit intomasterfrom
tt/orchestrator-version

Conversation

@tomasz-tylenda-sonarsource
Copy link
Copy Markdown

No description provided.

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Apr 10, 2026

Summary

Extracts the hardcoded maven-bundle-plugin version (2.3.7) into a Maven property in the guava project's pom.xml. This allows the plugin version to be overridden at build time (e.g., via parent POMs, profiles, or CLI parameters) while maintaining the same default behavior.

The change is minimal and non-functional — the plugin continues to use version 2.3.7, but now through a property reference instead of a hardcoded value. This is a Maven best practice for plugin management.

What reviewers should know

What to look for:

  • Single file change: guava/pom.xml
  • Two modifications:
    1. New property maven-bundle-plugin.version added to <properties>
    2. Plugin <version> element updated to reference the property

Context:
The change addresses SONARJAVA-6235, which likely flags hardcoded plugin versions as a code quality issue. Extracting to a property is the standard Maven solution.

Risk assessment:
Minimal. This is a build configuration change with no impact on runtime behavior. The plugin version remains 2.3.7; only how it's specified changes. If other POM files (parent POMs, profiles) rely on overriding this version, they can now do so — verify this aligns with your build setup if version overrides are used elsewhere.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, minimal change. No issues found.

🗣️ Give feedback

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit 89a7cc8 into master Apr 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants