Feature/sonarjava 2219 - Added another Annotation which was causing False Positives#1442
Feature/sonarjava 2219 - Added another Annotation which was causing False Positives#1442aepfli wants to merge 10 commits intoSonarSource:masterfrom
Conversation
* added missing ;
* fixing sonar issue regarding static
* adding @Inject again
* fixing test
* changing text
* adding @value for checked Annotations * adding @component to check for in class, dont know if this will be enough if somebody implements their own @component Annotation
# Conflicts: # java-checks/src/main/java/org/sonar/java/checks/spring/SpringComponentWithNonAutowiredMembersCheck.java # java-checks/src/test/files/checks/spring/SpringComponentWithNonAutowiredMembersCheck.java
* added missing import for test files
* i definitly should run the tests locally.. but right now, nothing is set up, so i am sorry to miss use your infrastructure
|
hmm not sure why this is failing... mvn clean package is running through locally... |
|
Hello @aepfli, your branch is conflicting with our master branch. I squashed all your commits when merging your first PR. It's probably the cause of the issue. Please restarted from rebased master branch, and only add the new commit on top of it. It will make things clear for us. I restarted Travis build. no idea why it failed. |
Hey guys!
With my last commit i think we did miss on the
@Valueannotation. I added it with this Pull-Request, i think that is it, i checked the JSR-250 and spring annotation, and did not find another field-based injection annotation!Br simon
PS: @m-g-sonar there is no internal ticket for now at your jira, so i reused the same number
Please ensure your pull request adheres to the following guidelines: