Batch rename sample files#4738
Merged
johann-beleites-sonarsource merged 20 commits intomasterfrom Apr 19, 2024
Merged
Conversation
johann-beleites-sonarsource
force-pushed
the
jb/rename-samples-2
branch
4 times, most recently
from
f28aa1b to
5d5476e
Compare
johann-beleites-sonarsource
force-pushed
the
jb/rename-samples-2
branch
2 times, most recently
from
1ada372 to
e3511c5
Compare
johann-beleites-sonarsource
force-pushed
the
jb/rename-samples-2
branch
from
e3511c5 to
4b81e4d
Compare
|
kaufco
approved these changes
Apr 19, 2024
Contributor
kaufco
left a comment
kaufco
left a comment
There was a problem hiding this comment.
Lgtm! Note that the test samples in non-compiling have their file name changed, but not the contained class names. I'm not sure whether this was your intention or not. If not, you can fix this in a separate PR maybe, because this one is already pretty big.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.