SONARJAVA-4935 S1192 should not report on individual lines of multi line string literal#4767
Merged
leonardo-pilastri-sonarsource merged 4 commits intomasterfrom Apr 15, 2024
Merged
Conversation
leonardo-pilastri-sonarsource
requested changes
Apr 15, 2024
Contributor
leonardo-pilastri-sonarsource
left a comment
leonardo-pilastri-sonarsource
left a comment
There was a problem hiding this comment.
Looks good to me! Just a simplification on a method.
Also I didn't want to mark multiple lines for formatting issues, can you reformat the code with the next commit?
Comment on lines
+143
to
+144
| private static BinaryExpressionTree asBinaryExpression(Tree tree, Tree.Kind kind) { | ||
| return tree.is(kind)? (BinaryExpressionTree) tree: null; |
Contributor
There was a problem hiding this comment.
Since we are only dealing with strings here, we will never need to use other kinds than PLUS, so we can remove the method's argument and adapt the other method calls in the check
Suggested change
| private static BinaryExpressionTree asBinaryExpression(Tree tree, Tree.Kind kind) { | |
| return tree.is(kind)? (BinaryExpressionTree) tree: null; | |
| private static BinaryExpressionTree asBinaryExpression(Tree tree) { | |
| return tree.is(Tree.Kind.PLUS) ? (BinaryExpressionTree) tree: null; |
|
leonardo-pilastri-sonarsource
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.