SONARJAVA-4975 Create custom rules plugin around symbolic execution engine#4798
Merged
leonardo-pilastri-sonarsource merged 11 commits intomasterfrom Jun 5, 2024
Merged
SONARJAVA-4975 Create custom rules plugin around symbolic execution engine#4798leonardo-pilastri-sonarsource merged 11 commits intomasterfrom
leonardo-pilastri-sonarsource merged 11 commits intomasterfrom
Conversation
leonardo-pilastri-sonarsource
force-pushed
the
lp-migrate-se-engine
branch
4 times, most recently
from
8702c6d to
b50bd3d
Compare
leonardo-pilastri-sonarsource
requested a review
from johann-beleites-sonarsource
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| <groupId>org.sonarsource.java</groupId> | |||
| <artifactId>java</artifactId> | |||
| <version>7.35.0-SNAPSHOT</version> | |||
| <version>7.36.0-SNAPSHOT</version> | |||
Contributor
There was a problem hiding this comment.
Revert back to 7.35
| OrchestratorBuilder orchestratorBuilder = Orchestrator.builderEnv() | ||
| .useDefaultAdminCredentialsForBuilds(true) | ||
| .setSonarVersion(System.getProperty("sonar.runtimeVersion", "LATEST_RELEASE")) | ||
| .setSonarVersion(System.getProperty("sonar.runtimeVersion", "LATEST_RELEASE[10.3]")) |
Contributor
There was a problem hiding this comment.
We need to change this back to LATEST_RELEASE
Comment on lines
+101
to
+102
| .addPlugin(MavenLocation.of("org.sonarsource.sonar-lits-plugin", "sonar-lits-plugin", "0.11.0.2659")) | ||
| .addPlugin(FileLocation.of(TestClasspathUtils.findModuleJarPath("../../java-symbolic-execution/java-symbolic-execution-plugin").toFile())); |
Contributor
There was a problem hiding this comment.
Can we add the symbolic execution plugin right after the Java plugin, for consistency?
|
|
||
| } | ||
|
|
||
| default void register(RegistrarContext registrarContext, CheckFactory checkFactory) { |
Contributor
There was a problem hiding this comment.
Let's add a javadoc comment here too
Comment on lines
+84
to
+85
| .map(repository::rule) | ||
| .forEach(rule -> rule.setTemplate(true)); |
Contributor
There was a problem hiding this comment.
Maybe we don't need a separate map invocation here, it seems to me that we can merge the map & the forEach for better readability.
Comment on lines
+30
to
+31
| assertThat(JavaSECheckList.getChecks()).isNotNull(); | ||
| assertThat(JavaSECheckList.getChecks()).hasSize(23); |
Contributor
There was a problem hiding this comment.
You can chain these assertions.
|
|
||
| @Test | ||
| void plugin() { | ||
| SonarRuntime runtime = SonarRuntimeImpl.forSonarQube(Version.create(10, 2), SonarQubeSide.SERVER, SonarEdition.DEVELOPER); |
Contributor
There was a problem hiding this comment.
Any reason we can't use the community edition here?
| @@ -80,7 +66,7 @@ void count() { | |||
| count++; | |||
| } | |||
| } | |||
| assertThat(CheckList.getChecks()).hasSize(count + SE_CHEKS.size()); | |||
| assertThat(CheckList.getChecks()).hasSize(count ); | |||
Contributor
There was a problem hiding this comment.
Suggested change
| assertThat(CheckList.getChecks()).hasSize(count ); | |
| assertThat(CheckList.getChecks()).hasSize(count); |
leonardo-pilastri-sonarsource
force-pushed
the
lp-migrate-se-engine
branch
from
ca66b78 to
4a2ad95
Compare
…ter rules into SonarJava repository
leonardo-pilastri-sonarsource
force-pushed
the
lp-migrate-se-engine
branch
from
4a2ad95 to
935558c
Compare
|
johann-beleites-sonarsource
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines: