SONARJAVA-5144 Update Custom rules documentation to match MyJavaFileCheckRegistrarTest#4903
Merged
erwan-serandour merged 2 commits intomasterfrom Oct 14, 2024
Merged
Conversation
dorian-burihabwa-sonarsource
approved these changes
Oct 14, 2024
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
LGTM! Feel free to apply the suggestion on the separate lines that form a single sentence.
Comment on lines
+569
to
+570
| To do so, navigate to its corresponding test class, named `MyJavaFileCheckRegistrarTest`, add your rule key to the end of the mainRuleKeys list | ||
| and your rule class name at the end of the mainCheckClasses list. |
Contributor
There was a problem hiding this comment.
We can probably put the whole sentence on single line here. This should help review changes to the text in the future
Suggested change
| To do so, navigate to its corresponding test class, named `MyJavaFileCheckRegistrarTest`, add your rule key to the end of the mainRuleKeys list | |
| and your rule class name at the end of the mainCheckClasses list. | |
| To do so, navigate to its corresponding test class, named `MyJavaFileCheckRegistrarTest`, add your rule key to the end of the mainRuleKeys list and your rule class name at the end of the mainCheckClasses list. |
erwan-serandour
force-pushed
the
erwan/update-custom-rules-tutorial
branch
from
ead0cbf to
6593694
Compare
erwan-serandour
force-pushed
the
erwan/update-custom-rules-tutorial
branch
from
6593694 to
bcc59dc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.