SONARJAVA-5344 Fix quality flaws

check-list/src/test/java/org/sonar/java/CheckListGeneratorTest.java

@@ -40,7 +40,7 @@ class CheckListGeneratorTest {
   private final String directory = System.getProperty("user.dir").replace("check-list", "");
 
   @BeforeEach
-  public void setUp() throws IOException {
+  void setUp() throws IOException {
     Gson gson = new Gson();
     generator = new CheckListGenerator(gson,
       Path.of(directory, "java-checks/src/main/java"),

java-checks/src/test/java/org/sonar/java/checks/helpers/JavadocTest.java

@@ -43,7 +43,7 @@ class JavadocTest {
   private static Javadoc invalidThrownExceptionUndocumented;
 
   @BeforeAll
-  public static void setup() {
+  static void setup() {
     File file = new File("src/test/files/checks/helpers/JavadocTest.java");
     tree = JParserTestUtils.parse(file);
 

java-checks/src/test/java/org/sonar/java/filters/AnyRuleIssueFilterTest.java

@@ -48,7 +48,7 @@ class AnyRuleIssueFilterTest {
   private FilterableIssue issue;
 
   @BeforeEach
-  public void setup() {
+  void setup() {
     issue = mock(FilterableIssue.class);
     when(issue.componentKey()).thenReturn(INPUT_FILE.key());
     when(issue.ruleKey()).thenReturn(RuleKey.of(REPOSITORY_KEY, RULE_KEY));

java-checks/src/test/java/org/sonar/java/filters/BaseTreeVisitorIssueFilterTest.java

@@ -50,7 +50,7 @@ class BaseTreeVisitorIssueFilterTest {
   private FilterableIssue issue;
 
   @BeforeEach
-  public void setup() {
+  void setup() {
     issue = mock(FilterableIssue.class);
     when(issue.componentKey()).thenReturn(INPUT_FILE.key());
     when(issue.ruleKey()).thenReturn(RuleKey.of(REPOSITORY_KEY, RULE_KEY));

java-checks/src/test/java/org/sonar/java/filters/PostAnalysisIssueFilterTest.java

@@ -44,7 +44,7 @@ class PostAnalysisIssueFilterTest {
   private FilterableIssue fakeIssue;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     postAnalysisIssueFilter = new PostAnalysisIssueFilter();
 
     context = mock(JavaFileScannerContext.class);

java-frontend/src/test/java/org/sonar/java/DefaultJavaResourceLocatorTest.java

@@ -40,7 +40,7 @@ class DefaultJavaResourceLocatorTest {
   private static final String TEST_BINARY_DIRS = "target/test/test-classes";
 
   @BeforeAll
-  public static void setup() {
+  static void setup() {
     ClasspathForMain javaClasspath = mock(ClasspathForMain.class);
     when(javaClasspath.getBinaryDirs()).thenReturn(Collections.singletonList(new File(BINARY_DIRS)));
     when(javaClasspath.getElements()).thenReturn(Collections.singletonList(new File(BINARY_DIRS)));

java-frontend/src/test/java/org/sonar/java/ast/JavaAstScannerTest.java

@@ -81,7 +81,7 @@ class JavaAstScannerTest {
   private SensorContextTester context;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     context = SensorContextTester.create(new File(""));
   }
 

java-frontend/src/test/java/org/sonar/java/ast/visitors/SonarSymbolTableVisitorTest.java

@@ -51,7 +51,7 @@ class SonarSymbolTableVisitorTest {
   private SonarComponents sonarComponents;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     context = SensorContextTester.create(temp.getRoot());
     sonarComponents = new SonarComponents(mock(FileLinesContextFactory.class), context.fileSystem(),
       mock(ClasspathForMain.class), mock(ClasspathForTest.class), mock(CheckFactory.class), mock(ActiveRules.class));

java-frontend/src/test/java/org/sonar/java/ast/visitors/SyntaxHighlighterVisitorTest.java

@@ -59,7 +59,7 @@ class SyntaxHighlighterVisitorTest {
   private SyntaxHighlighterVisitor syntaxHighlighterVisitor;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     context = SensorContextTester.create(temp.getRoot());
     sonarComponents = new SonarComponents(mock(FileLinesContextFactory.class), context.fileSystem(),
       mock(ClasspathForMain.class), mock(ClasspathForTest.class), mock(CheckFactory.class), mock(ActiveRules.class));

java-frontend/src/test/java/org/sonar/java/classpath/ClasspathForTestTest.java

@@ -41,7 +41,7 @@ class ClasspathForTestTest {
   public ThreadLocalLogTester logTester = new ThreadLocalLogTester().setLevel(Level.DEBUG);
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     fs = new DefaultFileSystem(new File("src/test/files/classpath/"));
     fs.add(TestUtils.emptyInputFile("foo.java", InputFile.Type.TEST));
     settings = new MapSettings();

java-frontend/src/test/java/org/sonar/java/model/DefaultInputFileScannerContextTest.java

@@ -63,7 +63,7 @@ public void endOfAnalysis(ModuleScannerContext context) {
   }
 
   @BeforeEach
-  public void setup() {
+  void setup() {
     sonarComponents = createSonarComponentsMock();
     compilationUnitTree = JParserTestUtils.parse(JAVA_FILE);
     context = new DefaultJavaFileScannerContext(compilationUnitTree, JAVA_INPUT_FILE, null, sonarComponents, new JavaVersionImpl(), true, false);

java-frontend/src/test/java/org/sonar/java/model/GeneratedFileTest.java

@@ -53,7 +53,7 @@ class GeneratedFileTest {
   private DefaultFileSystem fs;
 
   @BeforeEach
-  public void setUp() throws Exception {
+  void setUp() throws Exception {
     expected = tmp.resolve("file.jsp");
     Files.write(expected, "content".getBytes(UTF_8));
     fs = new DefaultFileSystem(tmp);

java-frontend/src/test/java/org/sonar/java/reporting/InternalJavaIssueBuilderTest.java

@@ -93,7 +93,7 @@ class InternalJavaIssueBuilderTest {
   private InputFile inputFile;
 
   @BeforeEach
-  public void setup() {
+  void setup() {
     SonarComponents sonarComponents = mock(SonarComponents.class);
     sensorContextTester = SensorContextTester.create(new File(""));
     when(sonarComponents.context()).thenReturn(sensorContextTester);
@@ -370,7 +370,7 @@ class QuickFixes {
     private CompilationUnitTree cut = JParserTestUtils.parse(JAVA_FILE);
 
     @BeforeEach
-    public void setup() {
+    void setup() {
       sct = Mockito.spy(SensorContextTester.create(new File("")));
       when(sct.newIssue()).thenReturn(new MockSonarLintIssue(sct));
 

java-surefire/src/test/java/org/sonar/plugins/surefire/SurefireJavaParserTest.java

@@ -46,7 +46,7 @@ class SurefireJavaParserTest {
   public LogTesterJUnit5 logTester = new LogTesterJUnit5().setLevel(Level.DEBUG);
 
   @BeforeEach
-  public void before() {
+  void before() {
     javaResourceLocator = mock(JavaResourceLocator.class);
     when(javaResourceLocator.findResourceByClassName(anyString())).thenAnswer(invocation -> new TestInputFileBuilder("", (String) invocation.getArguments()[0]).build());
 

java-surefire/src/test/java/org/sonar/plugins/surefire/SurefireSensorTest.java

@@ -48,7 +48,7 @@ class SurefireSensorTest {
   private PathResolver pathResolver = new PathResolver();
 
   @BeforeEach
-  public void before() {
+  void before() {
     fs = new DefaultFileSystem(new File("src/test/resources"));
     DefaultInputFile javaFile = new TestInputFileBuilder("", "src/org/foo/java").setLanguage("java").build();
     fs.add(javaFile);

java-surefire/src/test/java/org/sonar/plugins/surefire/data/SurefireStaxHandlerTest.java

@@ -33,7 +33,7 @@ class SurefireStaxHandlerTest {
   private UnitTestIndex index;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     index = new UnitTestIndex();
   }