SONARJAVA-4901 S6856 does not raise when parent class defines model attribute#5117
Merged
leonardo-pilastri-sonarsource merged 2 commits intomasterfrom May 1, 2025
Merged
Conversation
leonardo-pilastri-sonarsource
force-pushed
the
lp/SONARJAVA-4901
branch
from
4261963 to
58d9674
Compare
|
erwan-serandour
requested changes
May 1, 2025
|
|
||
| public class MissingPathVariableAnnotationCheckSample { | ||
|
|
||
| class ParentController { |
Contributor
There was a problem hiding this comment.
What happens if the parent is in a different file?
Contributor
Author
There was a problem hiding this comment.
At line 30 there is a case marked as FP where the MissingParentChildController extends MissingPathVariableParentInDifferentSample which is a different file. In those cases we do not have access to the parent class declaration and so we cannot see its methods, hence the FP
Contributor
There was a problem hiding this comment.
thank you 👍, I missed it
erwan-serandour
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SONARJAVA-4901
Part of