SONARJAVA-4917 S6857 support property placeholder inside SpEL#5128
Merged
erwan-serandour merged 13 commits intomasterfrom May 6, 2025
Merged
SONARJAVA-4917 S6857 support property placeholder inside SpEL#5128erwan-serandour merged 13 commits intomasterfrom
erwan-serandour merged 13 commits intomasterfrom
Conversation
romainbrenguier
requested changes
May 6, 2025
erwan-serandour
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for property placeholders inside SpEL expressions to address SONARJAVA-4917. Key changes include refactoring the string content checking methods to use a new ParseCtx, introducing new record types (Range, Placeholder, and ParseCtx), and updating error messaging and parsing logic for property placeholders and SpEL expressions.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java-checks/src/main/java/org/sonar/java/checks/spring/SpelExpressionCheck.java | Refactored parsing logic and error reporting for property placeholders and SpEL expressions using new types and methods. |
| java-checks-test-sources/default/src/main/java/checks/spring/SpelExpressionCheckSample.java | Updated test cases to reflect the new parsing behavior and error messages for property placeholders inside SpEL. |
Files not reviewed (1)
- its/autoscan/src/test/resources/autoscan/diffs/diff_S6857.json: Language not supported
Comments suppressed due to low confidence (2)
java-checks/src/main/java/org/sonar/java/checks/spring/SpelExpressionCheck.java:188
- [nitpick] Consider rephrasing the exception message to improve clarity and grammatical correctness (e.g., 'Range must be non-empty; start value must be less than end value.').
if (start >= end) { throw new IllegalArgumentException("a range is must be non empty, this imply start must be less than end"); }
java-checks-test-sources/default/src/main/java/checks/spring/SpelExpressionCheckSample.java:447
- [nitpick] Consider renaming 'PropertyPlaceHolderInsideSpEL' to 'PropertyPlaceholderInsideSpEL' for consistency in capitalization.
static class PropertyPlaceHolderInsideSpEL {
romainbrenguier
approved these changes
May 6, 2025
| throw new SyntaxError("Correct this malformed property placeholder.", range.addOffset(offset)); | ||
| } | ||
| } | ||
| private record ParseCtx(String expressionSource, int offset) { |
Contributor
There was a problem hiding this comment.
add a bit of doc here, in particular what's the offset
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SONARJAVA-4917