SONARJAVA-5494 Add rule for redundant new class name argument in transformClass call#5220
Merged
romainbrenguier merged 6 commits intomasterfrom Jul 1, 2025
Merged
SONARJAVA-5494 Add rule for redundant new class name argument in transformClass call#5220romainbrenguier merged 6 commits intomasterfrom
romainbrenguier merged 6 commits intomasterfrom
Conversation
romainbrenguier
force-pushed
the
romain/S7477
branch
4 times, most recently
from
1c89d31 to
3d2f157
Compare
erwan-serandour
requested changes
Jun 30, 2025
| .withCheck(new ClassNameInClassTransformCheck()) | ||
| .verifyIssues(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
let's test without semantics
|
|
||
| static class ExpressionMatcher { | ||
| @Nullable | ||
| ExpressionTree expressionTree; |
Contributor
There was a problem hiding this comment.
I think we can add private final
| ClassFile classFile = ClassFile.of(); | ||
| ClassModel classModel = classFile.parse(path); | ||
| return classFile.transformClass(classModel, | ||
| classModel.thisClass(), // Noncompliant |
Contributor
There was a problem hiding this comment.
I think it would be good to test the message name at some point
romainbrenguier
force-pushed
the
romain/S7477
branch
from
b79b1a3 to
1922eb7
Compare
romainbrenguier
force-pushed
the
romain/S7477
branch
from
1922eb7 to
3d66210
Compare
|
erwan-serandour
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5494