SONARJAVA-5772 Switch from testing object sizes to counting instance fields#5356
Merged
leonardo-pilastri-sonarsource merged 1 commit intobranch-8.9from Nov 14, 2025
Merged
Conversation
leonardo-pilastri-sonarsource
requested a review
from dorian-burihabwa-sonarsource
Comment on lines
+110
to
+127
| static class C { | ||
| private int x; | ||
| public long y; | ||
| HashSet<Object> hashSet; | ||
|
|
||
| C(int x) { | ||
| this.x = x; | ||
| } | ||
| } | ||
|
|
||
| static class D extends C { | ||
| char z; | ||
| static String staticField; | ||
|
|
||
| D(int x) { | ||
| super(x); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is this supposed to be in the test code?
Contributor
Author
There was a problem hiding this comment.
It was in the PR that was merged on master originally,https://github.com/SonarSource/sonar-java/pull/5305/files
I would keep it as it was for consistency
|
dorian-burihabwa-sonarsource
approved these changes
Nov 14, 2025
leonardo-pilastri-sonarsource
merged commit 8fb7056
into
branch-8.9
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5772