Conversation
hashicorp-vault-sonar-prod
Bot
changed the title
Contributor
rombirli
changed the title
asya-vorobeva
requested changes
Feb 10, 2026
|
|
||
| @Rule(key = "S8444") | ||
| public class PresuperLogicBloatsConstructorCheck extends FlexibleConstructorCheck { | ||
| private static final int MAX_STATEMENTS_BEFORE_CONSTRUCTOR_CALL = 3; |
Contributor
There was a problem hiding this comment.
We've decided about initial threshold = 5 AFAIR?
Contributor
Author
There was a problem hiding this comment.
Yes thank you, I didn't remember, applied it
| .onFile(nonCompilingTestSourcesPath("checks/PresuperLogicShoudntBloatConstructorSample.java")) | ||
| .withCheck(new PresuperLogicBloatsConstructorCheck()) | ||
| .withJavaVersion(25) | ||
| .verifyIssues(); |
Contributor
There was a problem hiding this comment.
Add the test to check that there are no issues for JDK24.
rombirli
changed the title
…exibleConstructorCheck # Conflicts: # java-checks/src/main/java/org/sonar/java/checks/FlexibleConstructorBodyValidationCheck.java
…oatConstructorSample
…icShoudntBloatConstructorSample - fix tests
rombirli
force-pushed
the
rombirli/SONARJAVA-6113-presuper-logic-shouldnt-bloat-constructor
branch
from
6d6430a to
493d4c1
Compare
|
rombirli
deleted the
rombirli/SONARJAVA-6113-presuper-logic-shouldnt-bloat-constructor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rspec PR : https://github.com/SonarSource/rspec/pull/6175