Conversation
| void test() { | ||
| CheckVerifier.newVerifier() | ||
| .onFile("src/test/files/checks/InnerStaticClassesCheckSample.java") | ||
| .onFile(nonCompilingTestSourcesPath("checks/InnerStaticClassesCheckSample.java")) |
There was a problem hiding this comment.
Why is it non-compiling? I think it should be regulat mainCodePath (or whatever the name was). Same below.
There was a problem hiding this comment.
After the first commit the Build and Unit Test on Windows failed because the sample file couldn't be parsed, that's why I moved this sample into non-compiling test source files in the second commit (see commit history)
There was a problem hiding this comment.
I moved it. PTAL. We can use either location for the existing sample. As for compact source file, your sample compiles, so it should be in mainCodeSourcesPath
rombirli
requested review from
aurelien-coet-sonarsource and
tomasz-tylenda-sonarsource
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
LGTM. Feel free to revert my commit.
|
rombirli
deleted the
rombirli/SONARJAVA-6121-fix-FP-S2694-on-compactsourcefile
branch
2 participants
No description provided.