Skip to content

SONARJAVA-6159 Update rule metadata: change formatting with new rule-api.jar#5490

Merged
tomasz-tylenda-sonarsource merged 2 commits intomasterfrom
gh-action/update-rule-metadata.22393588467
Feb 26, 2026
Merged

SONARJAVA-6159 Update rule metadata: change formatting with new rule-api.jar#5490
tomasz-tylenda-sonarsource merged 2 commits intomasterfrom
gh-action/update-rule-metadata.22393588467

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Feb 25, 2026

I did the followig to ensure that this large change is correct:

  • Checked with RSpec team on Slack that whitespace changes are intended
  • Build sonar-java-pluging, run it in a local SQ, and spot checked that changed files render correctly.
  • Used git diff --word-diff -w --word-diff-regex='[^[:space:]]+' master -- this unfortunatelly still shows when newline changes and there seems to be no workaround.
  • Tried difftastic, which is syntax aware, git -c diff.external=difft diff master -- newlines are still a problem but the output is much nicer
  • Used git show HEAD -- ':(exclude)*.html' to ensure that only html files are changed.
  • Asked Claude what changed excluding newline changes. It correctly identified changes to sonarpedia, S8447 and nothing more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a ticket for this?

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title Update rule metadata SONARJAVA-6159 Update rule metadata Feb 26, 2026
@tomasz-tylenda-sonarsource
Copy link
Copy Markdown
Contributor

Do we have a ticket for this?

Now we do. I just created one.

@dorian-burihabwa-sonarsource
Copy link
Copy Markdown
Contributor

  • Asked Claude what changed excluding newline changes. It correctly identified changes to sonarpedia, S8447 and nothing more.

Can we exclude the change to this rule and focus this ticket on updating white spaces ?

@tomasz-tylenda-sonarsource
Copy link
Copy Markdown
Contributor

  • Asked Claude what changed excluding newline changes. It correctly identified changes to sonarpedia, S8447 and nothing more.

Can we exclude the change to this rule and focus this ticket on updating white spaces ?

Done. I used S8447.html from master.

@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-6159 Update rule metadata SONARJAVA-6159 Update rule metadata: change formatting with new rule-api.jar Feb 26, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit a82667f into master Feb 26, 2026
15 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the gh-action/update-rule-metadata.22393588467 branch February 26, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants