Skip to content

SONARJAVA-6146 S8445: Relax the rule to allow more styles of sorting imports#5494

Merged
asya-vorobeva merged 1 commit intomasterfrom
asya/S8445-relax
Feb 27, 2026
Merged

SONARJAVA-6146 S8445: Relax the rule to allow more styles of sorting imports#5494
asya-vorobeva merged 1 commit intomasterfrom
asya/S8445-relax

Conversation

@asya-vorobeva
Copy link
Copy Markdown
Contributor

@asya-vorobeva asya-vorobeva commented Feb 26, 2026

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod bot commented Feb 26, 2026

SONARJAVA-6146

Copy link
Copy Markdown
Contributor

@rombirli rombirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we could do a few improvements

Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Copy link
Copy Markdown
Contributor

@rombirli rombirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I didn't approve yet because I think it would be great to move the sample files into a dedicated folder for this Check instead of mixing them with single-sample-file features in checks.

feel free to apply my 2 last suggestions on the code or not, it is more a matter of taste

Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Comment thread java-checks/src/main/java/org/sonar/java/checks/ImportDeclarationOrderCheck.java Outdated
Copy link
Copy Markdown
Contributor

@rombirli rombirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next
Copy link
Copy Markdown

@asya-vorobeva asya-vorobeva merged commit ac55c05 into master Feb 27, 2026
14 checks passed
@asya-vorobeva asya-vorobeva deleted the asya/S8445-relax branch February 27, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants