Skip to content

SONARJAVA-6070 S1133: Fix FP for deprecated code with documented migration paths#5522

Merged
asya-vorobeva merged 1 commit intomasterfrom
asya/s1133-fp
Mar 11, 2026
Merged

SONARJAVA-6070 S1133: Fix FP for deprecated code with documented migration paths#5522
asya-vorobeva merged 1 commit intomasterfrom
asya/s1133-fp

Conversation

@asya-vorobeva
Copy link
Contributor

@asya-vorobeva asya-vorobeva commented Mar 11, 2026

Rule S1133 now distinguishes between forgotten deprecated code and legitimate deprecation strategies by detecting:

  • Migration guidance (e.g., "use X instead", "replaced by Y", "{@link Z}")
  • Removal timelines (e.g., "will be removed in version X", "scheduled for removal")
  • Multiline @deprecated comments with proper continuation line handling

Part of SONARJAVA-6070

@hashicorp-vault-sonar-prod
Copy link
Contributor

hashicorp-vault-sonar-prod bot commented Mar 11, 2026

SONARJAVA-6070

@asya-vorobeva asya-vorobeva force-pushed the asya/s1133-fp branch 2 times, most recently from 633b6c1 to 1ebf257 Compare March 11, 2026 12:24
…ation paths

Rule S1133 now distinguishes between forgotten deprecated code and legitimate
deprecation strategies by detecting:
- Migration guidance (e.g., "use X instead", "replaced by Y", "{@link Z}")
- Removal timelines (e.g., "will be removed in version X", "scheduled for removal")
- Multiline @deprecated comments with proper continuation line handling

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@sonarqube-next
Copy link

Copy link
Contributor

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@asya-vorobeva asya-vorobeva merged commit 9d666d2 into master Mar 11, 2026
16 checks passed
@asya-vorobeva asya-vorobeva deleted the asya/s1133-fp branch March 11, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants